-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Wicher/more dkg edits #18384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
waamm
wants to merge
26
commits into
main
Choose a base branch
from
wicher/more-dkg-edits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Wicher/more dkg edits #18384
+6,198
−2,197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore into wicher/more-dkg-edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fptxtests and benches, need to be ported to weighted code (@rex1fernando )struct EncryptionKeytoweighted_fptxin the processark_serializecode (noticed by @ibalajiarun )vanishing_poly::from_roots()function, should be at least 10x faster nowFFT_THRESHfor the blstrs code, performs better on my M4 MaxarkworksandblstrsSCRAPE testschunky/chunkspublic so they can be used in testschunked_elgamal::PublicParametersto be generic over aCurveGrouprather than aPairingWeightedConfigBlstrsgeneric (toWeightedConfig<T>), and adding a test / benchmark caseSubTranscripttoSubtranscriptbatch_normalize()code to the sigma protocol... but I think we'll get rid of it againHow Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist