Skip to content

Conversation

@waamm
Copy link
Collaborator

@waamm waamm commented Dec 23, 2025

Description

  • Commented out fptx tests and benches, need to be ported to weighted code (@rex1fernando )
  • Moved struct EncryptionKey to weighted_fptx in the process
  • Got rid of duplicate ark_serialize code (noticed by @ibalajiarun )
  • Slightly refactored our arkworks random point generation so it also generates affine points
  • Modified vanishing_poly::from_roots() function, should be at least 10x faster now
  • Doubled FFT_THRESH for the blstrs code, performs better on my M4 Max
  • Wrote benches for the arkworks and blstrs SCRAPE tests
  • Made functions in chunky/chunks public so they can be used in tests
  • Changed chunked_elgamal::PublicParameters to be generic over a CurveGroup rather than a Pairing
  • Slightly edited PVSS tests by making WeightedConfigBlstrs generic (to WeightedConfig<T>), and adding a test / benchmark case
  • Renamed SubTranscript to Subtranscript
  • Added batch_normalize() code to the sigma protocol... but I think we'll get rid of it again

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants