SAMZA-2757 : Make Samza Compatible with Java 11 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-deee
changed the title
This was referenced May 8, 2023
malcolm-pro
reviewed
May 8, 2023
| DOWNLOAD_CACHE_DIR=$HOME/.samza/download | ||
| COMMAND=$1 | ||
| SYSTEM=$2 | ||
| YARN_VERSION="3.3.4" |
There was a problem hiding this comment.
Should this be flagged somehow to correspond with the version of Java being used, or maybe intentionally flagged? I believe Samza under Java 8 is still using Hadoop 2.10
Author
There was a problem hiding this comment.
I confirmed that using Java8 still works with this setup (meaning 3.3.4). So this whole system still works if you are running Java 8, It's just that this newer setup (if you use Samza 1.8.0) now works with Java 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparing things so that this app will work with Java 11. Once this Samza app PR is merged and released, we can update this to use the that version in the pom.xml file.
I am also deleting the gradle artifacts because this whole project is actually using Maven (not gradle, which was version 2 or something).
Verified that these version bumps (including the use of Scala 2.12 from Samza) all work. Note this moves Hadoop to be a Java 11 compatible version as well.
I have also tested with my local build from the Samza PR above, and using Java 11 that all of this works as well.