[QDP] test: add & refactor NumPy encoding tests for improved clarity and coverage #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verage - Updated test descriptions to better reflect functionality. - Consolidated encoding tests into parameterized cases for basic, large, and single sample inputs. - Introduced helper function to verify tensor properties, enhancing code reuse. - Added tests for different encoding methods and precision settings. - Implemented error handling tests for invalid inputs and unsupported dimensions.
Contributor
Author
|
cc @ryankert01 , @guan404ming , @400Ping , thx! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors and extends NumPy encoding tests to improve clarity, maintainability, and test coverage. The changes consolidate redundant test code into reusable helper functions and add new test cases for 2D array batch encoding, precision settings, and error handling.
Changes:
- Refactored three similar test functions into a single parameterized test with a helper function
- Added comprehensive test coverage for NumPy array encoding (both 1D and 2D)
- Added tests for encoding configurations (precision settings and encoding methods)
- Added error handling tests for invalid inputs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryankert01
approved these changes
Jan 15, 2026
Member
ryankert01
left a comment
ryankert01
left a comment
There was a problem hiding this comment.
Thanks for your contribution! LG!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Test Coverage:
.npyfiles)Related Issues or PRs
closes #823
Changes Made
Breaking Changes
Checklist
Additional
angleandbasisencoding methods (currently onlyamplitudeis implemented)