Skip to content

Conversation

@dentiny
Copy link

@dentiny dentiny commented Jan 4, 2026

Purpose of PR

This PR introduce dependabot, which automatically upgrades dependency on weekly basis.

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@400Ping
Copy link
Contributor

400Ping commented Jan 4, 2026

cc @rich7420 @guan404ming

Copy link
Member

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dentiny Is it making sense to add a python one also?

@dentiny
Copy link
Author

dentiny commented Jan 4, 2026

@dentiny Is it making sense to add a python one also?

make sense, but I almost never wrote python before, need to check more (vibe code one).

@rawkintrevo
Copy link
Contributor

rawkintrevo commented Jan 12, 2026

These things tend to break stuff in prod. We're not in prod, so it's ok, but you need to have a VERY robust testing in place before merging something like this.

Edit- by break, I mean some one changes something upstream (even patching a bug) then down stream (us) are also now borken. They can be useful too. I'm just saying proceed with caution (or good tests, so you'll know when somethign broke that it looks like no one has touched in 3 years, but then you see, ohh dependabot upgraded some stuff recently- the testing shortens the lag between the dependabot 'upgrade' and noticing its broken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants