Skip to content

KNOX-3062 - Fix an issue where group headers were not added to POST and PUT requests #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moresandeep wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KNOX-3062 - Fix an issue where group headers were not added to POST and PUT requests #933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/ConfigurableDispatch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,17 +168,24 @@ public void setGroupFilterPattern(@Default(DEFAULT_GROUP_FILTER_PATTERN) String
groupPattern = Pattern.compile(this.groupFilterPattern);
}

public void copyRequestHeaderFields(HttpUriRequest outboundRequest, HttpServletRequest inboundRequest, boolean shouldAddExpect100Header) {
super.copyRequestHeaderFields(outboundRequest, inboundRequest, shouldAddExpect100Header);
addPrincipalAndGroups(outboundRequest);
}

@Override
public void copyRequestHeaderFields(HttpUriRequest outboundRequest,
HttpServletRequest inboundRequest) {
super.copyRequestHeaderFields(outboundRequest, inboundRequest);
addPrincipalAndGroups(outboundRequest);
}

private void addPrincipalAndGroups(final HttpUriRequest outboundRequest) {
//If there are some headers to be appended, append them
Map<String, String> extraHeaders = getOutboundRequestAppendHeaders();
if(MapUtils.isNotEmpty(extraHeaders)){
extraHeaders.forEach(outboundRequest::addHeader);
}

/* If we need to add user and groups to outbound request */
if(shouldIncludePrincipalAndGroups) {
Map<String, String> groups = addPrincipalAndGroups();
Expand Down
Loading