Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered #16944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16944 +/- ##
============================================
+ Coverage 39.18% 39.30% +0.11%
Complexity 212 212
============================================
Files 5053 5056 +3
Lines 335671 337501 +1830
Branches 42812 42955 +143
============================================
+ Hits 131525 132643 +1118
- Misses 204146 204858 +712 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBKeyStoreLoaderClient.java
Fixed
Show fixed
Hide fixed
...main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBKeyStoreLoaderClient.java
Fixed
Show fixed
Hide fixed
...main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBKeyStoreLoaderClient.java
Fixed
Show fixed
Hide fixed
...main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBKeyStoreLoaderClient.java
Fixed
Show fixed
Hide fixed
...main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBKeyStoreLoaderClient.java
Fixed
Show fixed
Hide fixed
Caideyipi
changed the title
Caideyipi
changed the title
jt2594838
approved these changes
Dec 25, 2025
Comment on lines
227
to
230
| placeHolder = | ||
| parameters.getStringOrDefault( | ||
| Arrays.asList(CONNECTOR_OPC_UA_PLACEHOLDER_KEY, SINK_OPC_UA_PLACEHOLDER_KEY), | ||
| CONNECTOR_OPC_UA_PLACEHOLDER_DEFAULT_VALUE); |
Contributor
There was a problem hiding this comment.
placeHolder -> placeHolderForNullTag
Comment on lines
448
to
452
| if (Objects.nonNull(nameSpace)) { | ||
| nameSpace.transfer(tablet, isTableModel, this); | ||
| } else if (Objects.nonNull(client)) { | ||
| client.transfer(tablet, this); | ||
| } |
|
|
||
| public class IoTDBOpcUaClient { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(OpcUaNameSpace.class); | ||
| private static final int NAME_SPACE_INDEX = 2; |
Contributor
There was a problem hiding this comment.
Add a comment to explain this.
| null, // arrayDimensions | ||
| AccessLevel.toValue(AccessLevel.READ_WRITE), | ||
| AccessLevel.toValue(AccessLevel.READ_WRITE), | ||
| 500.0, // samplingInterval |
Contributor
There was a problem hiding this comment.
500 -> SAMPLING_INTERVAL_PLACE_HOLDER?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR