Skip to content

Conversation

@tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Oct 29, 2025

  • Add check for current year in NOTICE file copyright statement

    • Ensure copyright year is up-to-date (eg, 2024-$currentyear)
  • Add binary files detection in source tree

    • This check is inspired by Apache MADlib's rat-check script.
    • Check for common binary extensions (class, jar, tar, tgz, zip, exe, dll, so)
  • Improve workflow output and reporting

    • Add structured console output for both checks
    • Include check results in GitHub Actions job summary

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@tuhaihe
Copy link
Member Author

tuhaihe commented Oct 29, 2025

We have a few files in the .gz format:

$ find . -name "*.gz"

./gpMgmt/demo/gppkg/sample-sources.tar.gz
./contrib/formatter_fixedwidth/data/fixedwidth_small_correct.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/gz_multi_chunk_2.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/lineitem.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/gz_multi_chunk.tbl.gz
./src/bin/gpfdist/regress/data/exttab1/nation.tbl.gz

Should we delete them for better ASF compliance?

@leborchuk
Copy link
Contributor

We have a few files in the .gz format:

$ find . -name "*.gz"

./gpMgmt/demo/gppkg/sample-sources.tar.gz
./contrib/formatter_fixedwidth/data/fixedwidth_small_correct.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/gz_multi_chunk_2.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/lineitem.tbl.gz
./src/bin/gpfdist/regress/data/gpfdist2/gz_multi_chunk.tbl.gz
./src/bin/gpfdist/regress/data/exttab1/nation.tbl.gz

Should we delete them for better ASF compliance?

./gpMgmt/demo/gppkg/sample-sources.tar.gz - vote for delete it

As for others, maybe we should launch gpfdist and contrib/formatter_fixedwidth regress tests, and check if it is needed for regress tests or not. If not, let's delete it

* Add check for current year in NOTICE file copyright statement
  - Ensure copyright year is up-to-date (eg, 2024-$currentyear)

* Add binary files detection in source tree
  - This check is inspired by Apache MADlib's rat-check script.
  - Check for common binary extensions (class, jar, tar, tgz, zip, exe, dll, so)

* Improve workflow output and reporting
  - Add structured console output for both checks
  - Include check results in GitHub Actions job summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants