Fix core dumps triggered by rocksdb compacting when shutdown bk #4706
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
fix_rocksdb_compact_coredump
branch
from
560ace4 to
bc91be9
Compare
zymap
reviewed
Jan 21, 2026
Comment on lines
350
to
352
| while (!entryLocationIndex.compareAndSetCompacting(false, true)) { | ||
| Thread.sleep(100); | ||
| } |
Member
There was a problem hiding this comment.
Shouldn't it be done in the close method in the EntryLocationIndex?
AnonHxy
force-pushed
the
fix_rocksdb_compact_coredump
branch
from
ecaea19 to
7018ea1
Compare
AnonHxy
force-pushed
the
fix_rocksdb_compact_coredump
branch
from
1556a35 to
abee9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #4705
Motivation
Fix #4705
Changes
1.Setting the
compactingflag ofentryLocationIndexas true when shutdownLedgerStorageto stopping the subsequentcompact.2. When
LedgerStorageshutdown we will wait unit thecompactend.