Skip to content

Conversation

@claudevdm
Copy link
Collaborator

BigQueryIO.writeGenericRecord with storage API:

StorageApiDynamicDestinationsGenericRecord requires a TableSchema, converts the TableSchema to an AvroSchema using schemaFactory (default BigQueryAvroUtils::toGenericAvroSchema), then converts the avroSchema to a protoTableSchema.

This PR maps TIMESTAMP(12) BQ columns to Avro timestamp-nanos logical types so that the default schema factory

DEFAULT_AVRO_SCHEMA_FACTORY = BigQueryAvroUtils::toGenericAvroSchema;
can be used to write nanosecond precision timestamps with storage API.

I missed that there is a default schemafactory initially and just used passed a static AvroSchema in the schemafactory which serves as a workaround.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam BigQueryIO connector by enabling the correct handling of nanosecond precision timestamps when writing data to BigQuery via the Storage API. By modifying the default Avro schema factory, BigQuery's TIMESTAMP(12) type is now accurately mapped to Avro's timestamp-nanos logical type, ensuring data fidelity for high-resolution timestamp fields. This eliminates the need for manual workarounds and streamlines the process of writing detailed time-series data.

Highlights

  • BigQuery TIMESTAMP(12) to Avro timestamp-nanos mapping: The default schema factory now correctly maps BigQuery's TIMESTAMP(12) type to the Avro timestamp-nanos logical type. This allows for writing nanosecond precision timestamps to BigQuery using the Storage API.
  • Enhanced Timestamp Precision Handling: This change ensures that BigQueryIO.writeGenericRecord can properly handle and persist timestamps with nanosecond precision, addressing a previous limitation where a workaround was needed.
  • Integration Test Updates: The BigQueryTimestampPicosIT.java integration test has been updated to include a new ts_picos field, verifying the handling of higher precision timestamps within the test suite.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@claudevdm
Copy link
Collaborator Author

Failing tests are unrelated

@claudevdm claudevdm merged commit 139724d into apache:master Jan 9, 2026
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants