-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Map TIMSETAMP(12) BQ type -> timestamp-nanos Avro type in default schemafactory #37257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Apache Beam BigQueryIO connector by enabling the correct handling of nanosecond precision timestamps when writing data to BigQuery via the Storage API. By modifying the default Avro schema factory, BigQuery's TIMESTAMP(12) type is now accurately mapped to Avro's timestamp-nanos logical type, ensuring data fidelity for high-resolution timestamp fields. This eliminates the need for manual workarounds and streamlines the process of writing detailed time-series data. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
...oud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryTimestampPicosIT.java
Show resolved
Hide resolved
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Failing tests are unrelated |
BigQueryIO.writeGenericRecord with storage API:
StorageApiDynamicDestinationsGenericRecord requires a TableSchema, converts the TableSchema to an AvroSchema using schemaFactory (default BigQueryAvroUtils::toGenericAvroSchema), then converts the avroSchema to a protoTableSchema.
This PR maps TIMESTAMP(12) BQ columns to Avro timestamp-nanos logical types so that the default schema factory
beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
Line 643 in 6bedec3
I missed that there is a default schemafactory initially and just used passed a static AvroSchema in the schemafactory which serves as a workaround.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.