Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Nov 12, 2024

The PR is causing PostCommit Python to fail(https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python.yml) . I tried to fix it with #33083, but I did not get a clean test result. Trying to see if reverting it can make the test green.

#address #30513

@shunping shunping changed the title Fix postcommit python Revert PR #32960 Nov 12, 2024
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. will merge once tests pass

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Nov 12, 2024

PostCommit Python 3.9/3.11 is back green, same expect for the rest, merging for now

@Abacn Abacn merged commit 0f77934 into apache:master Nov 12, 2024
@liferoad
Copy link
Contributor

@damondouglas FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants