[AURON #1792] Keep the null result in the reverse connection result #1793
Conversation
cxzl25
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in Left Anti Join handling where NULL join keys were incorrectly included in the result set. The fix ensures NULL join keys are filtered out from Anti join results, which aligns with SQL NOT IN semantics where NULL NOT IN (...) evaluates to NULL (treated as false).
Key Changes
- Added explicit NULL join key handling for Anti joins that filters out rows with NULL keys
- Refactored the key validity check to be computed once before the conditional logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if P.mode == Anti && P.probe_is_join_side && !key_is_valid { | ||
| probed_joined.set(row_idx, true); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This fix correctly handles NULL join keys in Anti joins by filtering them out, which matches SQL NOT IN semantics. However, there's no test coverage for this specific scenario. Consider adding a test case for Anti joins with NULL join keys to prevent regression. The existing test in test.rs (join_anti function) only tests non-null keys.
2 participants
Which issue does this PR close?
Closes #1792
Rationale for this change
Keep the null result in the reverse connection result
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
cluster test