Skip to content

Conversation

@pawarprasad123
Copy link
Contributor

What changes were proposed in this pull request?

On Classic UI you can see isIncomplete property as true for shell entities get created but same entity when switched to React UI you can not see isIncomplete property appear

Fix provided:

  • The getValues function had an incorrect filter excluding isIncomplete:
  • The condition (keyValue == "isIncomplete" && keyValue == false) is invalid because keyValue is the property value (true/false), not the property name, so it can't be both the string "isIncomplete" and false.
  • Removed the isIncomplete filter so only profileData is filtered out. isIncomplete (or __isIncomplete) now displays regardless of value (true or false), matching Classic UI behavior.

How was this patch tested?

Manually
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

@FarhanKhan31 FarhanKhan31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants