-
Notifications
You must be signed in to change notification settings - Fork 132
feat: Add Auto-Like Feature with Channel Filtering and Improved Notifications #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution! Is this PR the same #1141? You can either try to separate the commits into the different PRs, or just close one of them and include a common description, as the proposed channel filter does not have any use except for the proposed auto-like functionality. |
|
Hi, thanks for replying! |
|
I will be adding some helper methods in the next beta to better deal with settings strings that are meant to be used as filters. The intent being to ensure that the parsing of any new filter strings follows the same rules as all the other filter strings without needing to duplicate the same code in multiple places. While I don't use the rating functionality, I think if you are adding an auto-like feature with a channel filter, then ideally it should be implemented in the following way:
Not fussed if you are not interested in adding the additional features mentioned above, but there are a few other things that can be improved on a bit:
Once the next beta is available, and the new helper methods can be used, I will provide more specific review comments. |
|
@MoojMidge Thanks for your detailed reply and suggestions. Also, I think ever since I added this feature, the watched markers are not working anymore ? |
That is a good point. As I mentioned, I don't make use of the rating functionality so if you think it doesn't make sense or have any use, then feel free to ignore the feature suggestions. What I did have in mind though was that because the filters used elsewhere in the addon do more than just match on the channel name, and also allow you to match on any available metadata for a video, you could potentially add a filter to dislike a video that you started watching, but then stopped watching shortly after, based on a filter for played percentage or played time.
I think it is because of this:
Try removing these additions and see how you go: |
What if the user clicked on the wrong video and closes it shortly after or opened the wrong add-on etc ?
I've removed it just now. :) Also... Pending Implementation (After Next Beta Release)
Auto-Rating Feature Enhancements
Code Clean-Up and Optimization
File to Review:
Thanks in advance! Looking forward to hearing your thoughts. |
That was why I suggested showing the existing rating dialog with a short timeout rather than just liking or disliking directly, so the user has an oportunity to dismiss the rating. But as I said if you don't think it is practical/useful then I won't insist on this being required. Everything else seems clear, but I am still working out some issues with the helper methods for channel matching #1159. There are issues with correctly identifying a channel based on four possible sources of identification:
|
|
Sorry for the lack of action on this. An update:
|
e71cbed to
f6ed59b
Compare
|
Have rebased and updated this PR to utilise some of the existing helper methods used for filtering/matching. Can you test and verify that it still works in the way you intended? |
…nnel name filtering, fix channel name extraction, update rate_video method, add language strings and filter settings
- Use setting constants and dedicated setting methods - Use existing helper method to parse filter string - Use existing helper method match against filter string and cache API lookups - Use existing methods to rate video - Only auto-like if video has been marked as watched - Avoid conflict between auto-like and existing rate after watching functionality - Reduce number of added settings - Reuse existing translatable strings where possible
f6ed59b to
c1f17a9
Compare
Add Auto-Like Feature with Channel Filtering and Improved Notifications
Description
This PR introduces a new auto-like feature that automatically likes watched videos. Additionally, it includes a channel filter system that lets users control which channels trigger auto-liking. Improved string handling and notifications enhance the overall user experience.
Changes
✅ New Auto-Like Feature:
rate_videomethod✅ Channel Filtering for Auto-Like:
✅ Technical Improvements:
Files Changed
resources/settings.xml(Added settings for auto-like and filtering)resources/language/resource.language.en_gb/strings.po(Defined new language strings)resources/lib/youtube_plugin/kodion/monitors/player_monitor.py(Implemented auto-like logic and improved player monitoring)Testing
✅ Verified that the auto-like setting appears correctly in the settings menu
✅ Tested auto-like functionality with different channel filters (whitelist & blacklist modes)
✅ Ensured proper notification text display when a video is auto-liked
✅ Confirmed no undefined string IDs are present
✅ Validated language string display across different languages
Additional Notes
This update introduces the auto-like feature for the first time, giving users the ability to automatically like watched videos. The channel filtering system ensures better control over which videos get liked, and improved notifications provide clear and consistent messaging.
Screenshots
📌 [Attach screenshots of settings and notifications if available]