Skip to content

Conversation

@jamOne-
Copy link
Contributor

@jamOne- jamOne- commented Nov 21, 2025

Most important:

  • In MatTableDataSource: Require T to extend from object, so the filtering works correctly.

Other changes should be harmless.

@jamOne- jamOne- marked this pull request as ready for review November 21, 2025 16:29
@jamOne- jamOne- requested a review from a team as a code owner November 21, 2025 16:29
@jamOne- jamOne- requested review from adolgachev and ok7sai and removed request for a team November 21, 2025 16:29
@jamOne-
Copy link
Contributor Author

jamOne- commented Nov 21, 2025

@andrewseguin PTAL

@jamOne-
Copy link
Contributor Author

jamOne- commented Nov 28, 2025

@andrewseguin apparently narrowing the MatTableDataSource type is a breaking change. WDYT how should we proceed with this?

@andrewseguin andrewseguin self-assigned this Dec 3, 2025
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 11, 2025
@andrewseguin andrewseguin merged commit aff31f1 into angular:main Dec 11, 2025
26 of 29 checks passed
@andrewseguin
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

andrewseguin pushed a commit that referenced this pull request Dec 11, 2025
* refactor(multiple): Remove any in sort, stepper, table, timepicker, tooltip, tree

* refactor(material/table): Require `T` to be object | ArrayLike

* refactor(material/tooltip): make message setter to accept `unknown`

* fix(material/tree): Fix tree tests after type changes

* refactor(multiple): approve api changes

* refactor(multiple): Fix MatTableDataSource and Tooltip types

* refactor(multiple): Fix MatTableDataSource T type and accept goldens

(cherry picked from commit aff31f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: material/table area: material/tooltip area: material/tree target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants