Create a new pull request by comparing changes across two branches #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant "src/app/" prefix from file headers (e.g., "src/app/open-close.component.ts" → "open-close.component.ts") to make code examples cleaner and more focused.
See associated pull request for more information.
See associated pull request for more information.
The example viewer has some `::ng-deep` styles that are used to reset global styles that leak into the live examples. It works by applying a style like `.docs-example-viewer-preview * {all: revert;}`.
The problem with this is that depending on when the first example is rendered, the styles will be lower or higher in the cascade, thus making the reset unreliable. Furthermore, it can affect structural styles from the CDK which intentionally have low specificity.
These changes move the resets into the global stylesheet to make them more predictable.
Fix the "Deferrable views" illustration which fixes the aligned within the `docs-card`.
This commit updates the unit testing, code coverage, and debugging guides to align with the Vitest test runner, which is now the default for new Angular CLI projects. Key changes include: - **Unit Testing Overview**: Revised to focus on Vitest, including details on DOM emulation (jsdom/happy-dom), browser testing setup, and custom Vitest configuration via `runnerConfig`. A prominent note links to the Karma-to-Vitest migration guide. - **Code Coverage**: Updated to reflect Vitest-specific prerequisites (`@vitest/coverage-v8`), command-line flags, and `angular.json` configuration for coverage reporting and threshold enforcement. - **Debugging**: Completely rewritten to provide instructions for debugging Vitest tests in both Node.js and browser environments using the `--debug` flag. - **Navigation Reordering**: The 'Testing' section in `sub-navigation-data.ts` has been reordered to present a more logical educational flow, starting with core concepts and progressing to advanced topics and migration.
This commit updates the testing documentation to include `bun` as a package manager option in all relevant code examples. Additionally, it standardizes the presentation of package manager commands by: - Consistently using a multi-tab format (`<docs-code-multifile>`). - Enforcing a consistent order: `npm`, `yarn`, `pnpm`, `bun`. These changes improve the user experience by providing clear instructions for multiple package managers and ensuring consistency across the testing guides.
Updated Angular adev cross repo docs files.
Add comprehensive guide for using npm link with Angular libraries, including required angular.json.
Removed redundant "src/app/" prefix from file headers (e.g. "src/app/open-close.component.ts" → "open-close.component.ts") to keep examples concise and avoid unnecessary path noise. Aligns with prior cleanup patterns (similar to #65016).
Code blocks with `bash` language identifier were not rendering the `$` prefix, while `shell` blocks did. This ensures consistent command-line prompt rendering across both `bash` and `shell` code blocks in the documentation.
- Replaced <a><button></button></a> with a proper <a> containing text and aria-label to ensure links have discernible text. - Added main tag in home page to provide a consistent main landmark, improving accessibility for screen readers and satisfying WCAG and Lighthouse requirements. Fixes #65181.
Updated shell command examples to use fenced code blocks (```shell) instead of components, improving formatting consistency and aligning with current documentation standards.
* Apply any debounce rules to updates from interop controls (if configured). * Add tests to ensure debouncing works for all control types (native, custom, and interop).
Increase the global font weight to `500`.
Ensure the content script forwards Angular detection results to the service worker so the popup/icon reflects the page state.
The actual numerical data can only be checked in the prop edit mode. This fixes that and makes the real value visible all the time.
Show the execution details of a captured frame entry only if there are recorded directives.
…erns - Removed unused code and imports - Migrated to signal-based input() APIs - Added readonly to Angular-initialized inputs and removed explicit type annotations - Updated templates to use self-closing tags for consistency
Updated bash command examples to use fenced code blocks (```bash) instead of <docs-code> components, improving formatting consistency and aligning with current documentation standards.
…tr. prefix requirement
…ht metadata
Replaced older <docs-code> components (e.g.
<docs-code language="ts" highlight="3">…</docs-code>)
with modern fenced code blocks using {highlight:[3]} metadata
…on popup Adds target="_blank" and rel="noopener noreferrer" to prevent tab-nabbing and follow modern security best practices.
…tOutlet Removes the `ngComponentOutletNgModuleFactory` in `_needToReCreateNgModuleInstance`
The type checker will no longer prohibit binding the Signal Forms `[field]` directive to an input with a dynamic `[attr.type]` or `[type]` binding.
See associated pull request for more information.
Adds a DI configuration option for signal forms that allows the developer to specify CSS classes that should be automatically added by the `Field` directive based on the field's status.
Now you can do form.reset({name: 'cat', age: 4});
Fix anchor link for Dependency Injection Overview.
Escape @-prefixed template control flow constructs during doc extraction so JSDoc parsing keeps description text intact. Add regression coverage for @for snippets.
This ensures that the right document is used and that `CSP_NONCE` can be used in `provideAppInitializer` and `provideEnvironmentInitializer`. Closes #65624
Adds a mark for signal forms so we can track adoption. Also moves the call for `@let` into `declareLet` since we don't need it to fire as often as in `storeLet`.
This replaces `getDocument()` with `inject(DOCUMENT)` across hydration and transfer state logic.
The XSRF interceptor previously failed to detect protocol-relative URLs (starting with `//`) as absolute URLs. This allowed requests to such URLs to include the XSRF token, potentially leaking it to external domains. This change updates the interceptor to correctly identify protocol-relative URLs as absolute and exclude them from receiving the XSRF token.
Improves the rendering of `DocsPillRow` to correctly display inline code snippets (using backticks) within the pill labels.
Add test coverage for bundling dynamic component creation API like `createComponent()` and `inputBinding()`. This will be used to test that Signal Forms related features for #64632 can be tree-shaken when unused.
See associated pull request for more information.
When a signal throws an error on read. The formatter will show the error message.
…ormatter for signal errors When signals throw errors on read, the devtools will show the same error message as the signal custom formatter. We also don't log errors anymore to the console as those might be surprising to see as errors and are buggy behavior of the devtools.
Fixed form custom control example uses non-working syntax in template Fix #65647
See associated pull request for more information.
…n` on zoneless apps. With the change we specifically analyse `boostrapApplication` with a config that uses `mergeApplicationConfig`. fixes #65408
GulajavaMinistudio
merged commit 4fbe842
into
angular-indonesia:main
4 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information