-
Notifications
You must be signed in to change notification settings - Fork 7
Use build args for versions #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removes the need for update.sh Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
|
Why RCs? |
|
We need to test against RCs, otherwise we end up with big surprises on release day. Master is too volatile, and would result in a lot of failures that we can't do anything about. |
|
We do test against master in Swarm - we don't want to wait until RCs before finding out that the API is broken, which happens about once a month /cc @vieux |
|
Makes sense, we have slightly different requirements here. From Compose we only care about backwards compatibility and a few new features we plan on using, so we can wait for RC to find any breaking changes. For Swarm you need to actually have API compatibility, so finding out about changes asap is important. Are you still using this image for Swarm? I thought you were using dind-master exclusively ? I have been uploading RC images to hub for a couple releases now. |
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
The single binary is now a tarball. Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Build all missing tags
Signed-off-by: Joffrey F <joffrey@docker.com>
Adapt script to use new distribution channels
Signed-off-by: Joffrey F <joffrey@docker.com>
Use `dockerd` in test.sh
Signed-off-by: Joffrey F <joffrey@docker.com>
Account for new archive name
Signed-off-by: Joffrey F <joffrey@docker.com>
Updated arch_suffix test
Now that build args exist, it's a lot easier to do updates for this image.
I've made
VERSIONan arg, and the "check for existing" just look for the image instead of a git tag. That way we don't need git tags or to push to a git repo to do updates.I think this will make it much easier to run as a jenkins job.