[UPD] Updated 'on demand' feature

[mpvphd]

1. Manifest updated

---

2. Default value of on_demand
   1. set to False

---

3. Tests of on_demand
   1. Test Default Value of on_demand:
      • Ensures that the default value of the on_demand attribute on the product is False.
   2. Test Inheritance and Setting of on_demand:
      • Verifies that setting on_demand on a specific product instance correctly inherits and reflects its value when calling _stock_state_check_on_demand().
   3. Test Computation of Stock State When on_demand is True:
      • Confirms that the computed stock state is set to 'on_demand' regardless of the previous state,

---

4. Updated view 'on demand' feature display in product.template view
   1. state_thershold not shown in view if on_demand is True

---

[ak-git-bot]

Hi @kevinkhao, @sebastienbeau, @legalsylvain,
some modules you are maintaining are being modified, check this out!

[mourad-ehm]

I think that by default we get False value for Boolean fields

[mpvphd]

True !
in the end this is useless but harmless piece of code too ^^
thx

[hparfr]

useless test

[hparfr]

useless

[hparfr]

@mpvphd

Can you please fix the tests by

• removing useless tests
• adding a simple test case :
  • set stock level to x, set on_demand = true, set threshold = y (with x < y), expect state = on_demand
  • set stock level to x, set on_demand = true, set threshold = z (with z > y), expect stated= on_demand

[mpvphd]

@hparfr

• please be more specific; indeed, the “usefulness” is a matter of point of view (To clarify this point, the test checks that no state overrides on_demand as soon as on_demand is true)
• test_06_state_on_demand_computation test follows the existing logic, similar to test_05_state_out_of_stock, which does not depend on stock quantity properties (such as amount or threshold). Adding stock quantity-dependent checks would be unnecessary and inconsistent with the original test design.

[hparfr]

test_06_state_on_demand_computation test follows the existing logic, similar to test_05_state_out_of_stock, which does not depend on stock quantity properties (such as amount or threshold). Adding stock quantity-dependent checks would be unnecessary and inconsistent with the original test design.

No.
I ask to write a test to clarify a behavior: what happens if there is stock for a product on_demand. As it is written now; the test 06 do not show this behavior.