Skip to content

Conversation

@sleepybnuuy
Copy link
Contributor

have seen yellow outlines used in vanilla with the Highlight Potential Targets setting and during housing editing, but not sure of any uses of the other colors. lmk of any changes needed

Copy link
Collaborator

@wolfcomp wolfcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so we don't have extra enums that have to be maintained later down the line.

Comment on lines +28 to +48


/// <summary>
/// certain objects may require Visible bit set in addition to a color, without this they fail to draw entirely
/// </summary>
/// <remarks>
/// 0x70 and higher cause pink heatmap effects with motion, possibly a render glitch?
/// </remarks>
[Flags]
public enum Outline : byte {
/// <summary>
/// no color on its own, used in combination with other bits
/// </summary>
Default = 0x03,
Red = ObjectHighlightColor.Red << 4,
Green = ObjectHighlightColor.Green << 4,
Blue = ObjectHighlightColor.Blue << 4,
Yellow = ObjectHighlightColor.Yellow << 4,
Orange = ObjectHighlightColor.Orange << 4,
Magenta = ObjectHighlightColor.Magenta << 4
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <summary>
/// certain objects may require Visible bit set in addition to a color, without this they fail to draw entirely
/// </summary>
/// <remarks>
/// 0x70 and higher cause pink heatmap effects with motion, possibly a render glitch?
/// </remarks>
[Flags]
public enum Outline : byte {
/// <summary>
/// no color on its own, used in combination with other bits
/// </summary>
Default = 0x03,
Red = ObjectHighlightColor.Red << 4,
Green = ObjectHighlightColor.Green << 4,
Blue = ObjectHighlightColor.Blue << 4,
Yellow = ObjectHighlightColor.Yellow << 4,
Orange = ObjectHighlightColor.Orange << 4,
Magenta = ObjectHighlightColor.Magenta << 4
}

Comment on lines +14 to +17
/// <summary>
/// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight
/// </summary>
[FieldOffset(0x89)] public Outline OutlineFlags;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <summary>
/// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight
/// </summary>
[FieldOffset(0x89)] public Outline OutlineFlags;
/// <summary>
/// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight
/// </summary>
/// <remarks>
/// (&amp; 0xF0) >> 4 == ObjectHighlightColor
/// &amp; 0x0F == other state (3 = Default)
/// </remarks>
[FieldOffset(0x89)] public byte OutlineFlags;

Comment on lines +1 to 3
using FFXIVClientStructs.FFXIV.Client.Game.Object;

namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using FFXIVClientStructs.FFXIV.Client.Game.Object;
namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene;
namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants