-
Notifications
You must be signed in to change notification settings - Fork 218
DrawObject outline offset #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wolfcomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so we don't have extra enums that have to be maintained later down the line.
|
|
||
|
|
||
| /// <summary> | ||
| /// certain objects may require Visible bit set in addition to a color, without this they fail to draw entirely | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// 0x70 and higher cause pink heatmap effects with motion, possibly a render glitch? | ||
| /// </remarks> | ||
| [Flags] | ||
| public enum Outline : byte { | ||
| /// <summary> | ||
| /// no color on its own, used in combination with other bits | ||
| /// </summary> | ||
| Default = 0x03, | ||
| Red = ObjectHighlightColor.Red << 4, | ||
| Green = ObjectHighlightColor.Green << 4, | ||
| Blue = ObjectHighlightColor.Blue << 4, | ||
| Yellow = ObjectHighlightColor.Yellow << 4, | ||
| Orange = ObjectHighlightColor.Orange << 4, | ||
| Magenta = ObjectHighlightColor.Magenta << 4 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// <summary> | |
| /// certain objects may require Visible bit set in addition to a color, without this they fail to draw entirely | |
| /// </summary> | |
| /// <remarks> | |
| /// 0x70 and higher cause pink heatmap effects with motion, possibly a render glitch? | |
| /// </remarks> | |
| [Flags] | |
| public enum Outline : byte { | |
| /// <summary> | |
| /// no color on its own, used in combination with other bits | |
| /// </summary> | |
| Default = 0x03, | |
| Red = ObjectHighlightColor.Red << 4, | |
| Green = ObjectHighlightColor.Green << 4, | |
| Blue = ObjectHighlightColor.Blue << 4, | |
| Yellow = ObjectHighlightColor.Yellow << 4, | |
| Orange = ObjectHighlightColor.Orange << 4, | |
| Magenta = ObjectHighlightColor.Magenta << 4 | |
| } |
| /// <summary> | ||
| /// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight | ||
| /// </summary> | ||
| [FieldOffset(0x89)] public Outline OutlineFlags; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// <summary> | |
| /// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight | |
| /// </summary> | |
| [FieldOffset(0x89)] public Outline OutlineFlags; | |
| /// <summary> | |
| /// used in vanilla with Highlight Potential Targets, Housing object outlines. can be set by GameObject.Highlight | |
| /// </summary> | |
| /// <remarks> | |
| /// (& 0xF0) >> 4 == ObjectHighlightColor | |
| /// & 0x0F == other state (3 = Default) | |
| /// </remarks> | |
| [FieldOffset(0x89)] public byte OutlineFlags; |
| using FFXIVClientStructs.FFXIV.Client.Game.Object; | ||
|
|
||
| namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| using FFXIVClientStructs.FFXIV.Client.Game.Object; | |
| namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene; | |
| namespace FFXIVClientStructs.FFXIV.Client.Graphics.Scene; |
have seen yellow outlines used in vanilla with the Highlight Potential Targets setting and during housing editing, but not sure of any uses of the other colors. lmk of any changes needed