-
Notifications
You must be signed in to change notification settings - Fork 58
feat: show collab user for same user #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
I remember having discussions with @karlpauls and @bosschaert about this. We opted to mimic the same behavior as Google Docs (or was it Word?). Having now lived with this, I think this is a good change. We should tell you if you have the doc open multiple times. |
Today - if you have multiple tabs opened editing the same document:
This PR enables the icon to appear for each tab you have opened - here I have it 6x times opened and the caret is positioned for editing in another tab (focus remains in the other tab, screenshot is for illustration):
This might help users to know they have the document opened somewhere else in their browser and reduce the number of opened tabs.
Test page: https://sameuser--da-live--adobe.aem.live/ (edit a page you have access too).
The PR also contains the fix of the e2e tests which revealed the issue: