Skip to content

Fix: Deprecated config for _shouldSubmitScore (fixes #3740) #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 1 commit into from
Jan 8, 2026
Merged

Fix: Deprecated config for _shouldSubmitScore (fixes #3740) #3741

oliverfoster merged 1 commit into from
Jan 8, 2026

Conversation

@joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Jan 5, 2026

Fix

Testing

  1. Install vanilla Adapt.
  2. Check for warning message calling out depreciated configuration as indicated in Default course: DEPRECATED config #3740

@joe-replin
Update config.json
f1ff8a5 
Added '_shouldSubmitScore' to completion criteria and removed it from tracking.
@joe-replin joe-replin self-assigned this Jan 5, 2026
@joe-replin joe-replin added the bug label Jan 5, 2026
@joe-replin joe-replin moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jan 5, 2026
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck changed the title Fix: Depreciated config (fixes #3740) Fix: Deprecated config (fixes #3740) Jan 6, 2026
@swashbuck swashbuck changed the title Fix: Deprecated config (fixes #3740) Fix: Deprecated config for _shouldSubmitScore (fixes #3740) Jan 6, 2026
@oliverfoster oliverfoster merged commit d39011a into master Jan 8, 2026
2 checks passed
@oliverfoster oliverfoster deleted the issue/3740 branch January 8, 2026 10:16
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🎉 This PR is included in version 5.54.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-replin joe-replin

Labels

bug dependencies released

Projects

adapt_framework: The TODO Board
Status: Recently Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default course: DEPRECATED config

5 participants

@joe-replin @swashbuck @oliverfoster @cahirodoherty-learningpool