v1.3.1 + zig build files

[precla]

for reasons to me yet unknown: it builds fine if the file zconf.h is deleted. Fails with a lot of errors if the file exists

log:

$ zig build
install
└─ install zlib
   └─ zig build-lib zlib Debug native 10 errors
zlib/gzlib.c:242:9: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations
        LSEEK(state->fd, 0, SEEK_END);  /* so gzoffset() is correct */
        ^
zlib/gzlib.c:14:17: note: expanded from macro 'LSEEK'
#  define LSEEK lseek
                ^
zlib/gzlib.c:248:24: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations
        state->start = LSEEK(state->fd, 0, SEEK_CUR);
                       ^
zlib/gzlib.c:14:17: note: expanded from macro 'LSEEK'
#  define LSEEK lseek
                ^
zlib/gzlib.c:332:9: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations
    if (LSEEK(state->fd, state->start, SEEK_SET) == -1)
        ^
zlib/gzlib.c:14:17: note: expanded from macro 'LSEEK'
#  define LSEEK lseek
                ^
zlib/gzlib.c:369:15: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations
        ret = LSEEK(state->fd, offset - (z_off64_t)state->x.have, SEEK_CUR);
              ^
zlib/gzlib.c:14:17: note: expanded from macro 'LSEEK'
#  define LSEEK lseek
                ^
zlib/gzlib.c:455:14: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations
    offset = LSEEK(state->fd, 0, SEEK_CUR);
             ^
zlib/gzlib.c:14:17: note: expanded from macro 'LSEEK'
#  define LSEEK lseek
                ^
zlib/gzwrite.c:78:20: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations
            writ = write(state->fd, strm->next_in, put);
                   ^
zlib/gzwrite.c:108:24: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations
                writ = write(state->fd, state->x.next, put);
                       ^
zlib/gzwrite.c:627:9: error: call to undeclared function 'close'; ISO C99 and later do not support implicit function declarations
    if (close(state->fd) == -1)
        ^
zlib/gzread.c:22:15: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations
        ret = read(state->fd, buf + *have, get);
              ^
zlib/gzread.c:599:11: error: call to undeclared function 'close'; ISO C99 and later do not support implicit function declarations
    ret = close(state->fd);
          ^
error: the following command failed with 10 compilation errors:
/usr/bin/zig build-lib -cflags -Wall -Wextra -Wpedantic -- zlib/adler32.c zlib/compress.c zlib/crc32.c zlib/deflate.c zlib/gzclose.c zlib/gzlib.c zlib/gzread.c zlib/gzwrite.c zlib/infback.c zlib/inffast.c zlib/inflate.c zlib/inftrees.c zlib/trees.c zlib/uncompr.c zlib/zutil.c -ODebug -Mroot -lc --cache-dir zlib/.zig-cache --global-cache-dir /home/user/.cache/zig --name zlib -static --listen=- 
Build Summary: 0/3 steps succeeded; 1 failed (disable with --summary none)
install transitive failure
└─ install zlib transitive failure
   └─ zig build-lib zlib Debug native 10 errors
error: the following build command failed with exit code 1:
zlib/.zig-cache/o/cfe7f527f4c329cbb0f1ed2a38d6cd0f/build /usr/bin/zig zlib zlib/.zig-cache /home/user/.cache/zig --seed 0xf5590a51 -Z8b27aa865680b995

[precla]

@plajjan can you update your develop branch, then git checkout v1.3.1 and push that as a branch? i'd like to target v1.3.1 to avoid having zlib commits

[plajjan]

Right, so that zlib ships a zconf.h seems like a problem. In the CMakeLists.txt the zconf.h is moved out of the way in order to make room for the one that CMake generates from zconf.h.cmakein.

if(NOT CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_CURRENT_BINARY_DIR)
    # If we're doing an out of source build and the user has a zconf.h
    # in their source tree...
    if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h)
        message(STATUS "Renaming")
        message(STATUS "    ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h")
        message(STATUS "to 'zconf.h.included' because this file is included with zlib")
        message(STATUS "but CMake generates it automatically in the build directory.")
        file(RENAME ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h ${CMAKE_CURRENT_SOURCE_DIR}/zconf.h.included)
  endif()
endif()

I tried adding some code to build a config header from zconf.h.cmakein but it is basically moot because it becomes available by zconf.h but it is shadowed by the already existing zconf.h. The CMake config above moves the zconf.h but I don't think that's possible with build.zig because it's truly a out-of-tree build, so we can't really touch the source directory I think. I mean, build.zig is a normal zig program, so we can of course do anything we want, but it's not what is supposed to happen.

I am ready to consider the upstream zlib basically broken. It seems wrong to ship a zconf.h like this. I presume it is done to enable some very basic building without cmake or similar, still though, seems bad.

Our goal is to have a working build.zig. It's just a branch off of the v1.3.1 (and in the future some other version tag). It's ok if we break some other build toolchain I think, so let's just remove the zconf.h file, right?

[plajjan]

@precla I have pulled in the changes to develop branch from upstream so I guess you can rebase!?

[precla]

@precla I have pulled in the changes to develop branch from upstream so I guess you can rebase!?

i'd rather close it now that we have the zig-kll branch

It's ok if we break some other build toolchain I think, so let's just remove the zconf.h file, right?

yup, we don't really need to care about some other toolchain if it builds fine with zig