Skip to content

Conversation

@Ashish-walkingn8mare
Copy link
Contributor

This pull request introduces a new structured logging system to the codebase and refactors all previous usage of fmt.Println and log.Println to use the new logger. Additionally, it updates documentation and build requirements to support Go 1.23. The most important changes are grouped below.

Logging System Integration

  • Added a new logger interface and a default no-op logger in lib/logger/logger.go and lib/logger/no-op.go, providing a unified logging API for the project. [1] [2]
  • Replaced all fmt.Println and log.Println statements across lib/browser_manager, lib/renderer, and lib/signer with calls to the new logger, ensuring consistent log formatting and supporting structured fields. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]

Build and Environment Compatibility

  • Updated the Go version requirement from 1.22 to 1.23 in README.md and lib/go.mod to reflect the need for the latest language features and compatibility. [1] [2]
  • Improved the Makefile to support both docker-compose and docker compose commands for better compatibility across different environments. [1] [2] [3]

Documentation Updates

  • Updated integration examples in docs/Integration.md to use the correct templatestore.StorageConfig type, reflecting recent API changes. [1] [2] [3]

These changes collectively improve logging consistency, developer experience, and documentation accuracy.

x-sushant-x and others added 18 commits April 21, 2025 22:12
feat(logger): add support for pluggable logging libraries
Integrated logging changes in `service`
fix(espresso): updated golang version to 1.23, updated docs
fix(makefile): updated makefile to detect docker command, updated readme
fix: timestamp not displayed in logs & added log to service layer
fix(logging): renamed time to duration in logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants