-
Notifications
You must be signed in to change notification settings - Fork 38
d2m #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ashish-walkingn8mare
wants to merge
18
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
d2m #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(logger): add support for pluggable logging libraries
Integrated logging changes in `service`
fix(espresso): updated golang version to 1.23, updated docs
fix(makefile): updated makefile to detect docker command, updated readme
fix: timestamp not displayed in logs & added log to service layer
fix(logging): renamed time to duration in logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new structured logging system to the codebase and refactors all previous usage of
fmt.Printlnandlog.Printlnto use the new logger. Additionally, it updates documentation and build requirements to support Go 1.23. The most important changes are grouped below.Logging System Integration
lib/logger/logger.goandlib/logger/no-op.go, providing a unified logging API for the project. [1] [2]fmt.Printlnandlog.Printlnstatements acrosslib/browser_manager,lib/renderer, andlib/signerwith calls to the new logger, ensuring consistent log formatting and supporting structured fields. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]Build and Environment Compatibility
README.mdandlib/go.modto reflect the need for the latest language features and compatibility. [1] [2]Makefileto support bothdocker-composeanddocker composecommands for better compatibility across different environments. [1] [2] [3]Documentation Updates
docs/Integration.mdto use the correcttemplatestore.StorageConfigtype, reflecting recent API changes. [1] [2] [3]These changes collectively improve logging consistency, developer experience, and documentation accuracy.