-
Notifications
You must be signed in to change notification settings - Fork 39
feat(lib): add a config package to load application configuration using Viper #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akkahshh24
wants to merge
6
commits into
Zomato:dev
Choose a base branch
from
akkahshh24:feature/config_lib_dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
99aacea
Add mapstructure tags
akkahshh24 26a1e36
Rectify field name
akkahshh24 145b989
Pass browserPath to Init function
akkahshh24 d2c15be
Pass browser path in test file
akkahshh24 1090536
add mapstructure tags to CertificateConfig struct for proper unmarsha…
akkahshh24 293dbd4
add CredentialStore to load certificates and keys at the time of appl…
akkahshh24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package certmanager | ||
|
|
||
| import "context" | ||
|
|
||
| type CredentialStore struct { | ||
| credentials map[string]*SigningCredentials | ||
| } | ||
|
|
||
| func NewCredentialStore(credentials map[string]CertificateConfig) (*CredentialStore, error) { | ||
|
|
||
| credentialStore := CredentialStore{ | ||
| credentials: make(map[string]*SigningCredentials), | ||
| } | ||
|
|
||
| for key, config := range credentials { | ||
| cred, err := LoadSigningCredentials(context.Background(), &config) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| credentialStore.credentials[key] = cred | ||
| } | ||
|
|
||
| return &credentialStore, nil | ||
| } | ||
|
|
||
| func (cs *CredentialStore) GetCredential(key string) (*SigningCredentials, bool) { | ||
| creds, exists := cs.credentials[key] | ||
| return creds, exists | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the use of the
mapstructuretag?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used by Viper to map the field name in the configuration file to the name in our Go struct.
For example,
uploader_concurrencyfrom the YAML file should be mapped toUploaderConcurrencyin our struct.