-
Notifications
You must be signed in to change notification settings - Fork 233
Better comm system #5610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Better comm system #5610
Conversation
| @@ -0,0 +1,245 @@ | |||
| return { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in file name.
|
Thanks, I have had a bit of a look although won't have time for a full look for a few weeks. I like the approach of splitting things into multiple files like this. I am concerned about the global I'd be a lot happier without the interfile globals and the metatables.With them, this might end up being too much of a maintainability risk. |
|
Also it should be indented with tabs. |
|
Updated. Removed global |
|
Scary amount of changes for so few commits. Would be nice if this was cut into minimal commits |
merged related datas about commanders to single files. (just find, move and Include, so they keeps origin structure, just in another files)
Tested with Chicken comm, start select, morph, weapon, shield, damage and range mod.