Skip to content

Use assertEqualHTML styles HTML tests #10644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 2 commits into from
Closed

Use assertEqualHTML styles HTML tests #10644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b7fcef
Update styles tests to use assertEqualHTML
sirreal Dec 17, 2025
4bb884d
Simplify conditional style no-print test
sirreal Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions tests/phpunit/tests/dependencies/styles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function test_wp_enqueue_style() {
$expected .= "<link rel='stylesheet' id='no-deps-null-version-css' href='http://example.com' type='text/css' media='all' />\n";
$expected .= "<link rel='stylesheet' id='no-deps-null-version-print-media-css' href='http://example.com' type='text/css' media='print' />\n";

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );

// No styles left to print.
$this->assertSame( '', get_echo( 'wp_print_styles' ) );
Expand All @@ -88,7 +88,7 @@ public function test_wp_enqueue_style_with_html5_support_does_not_contain_type_a
$ver = get_bloginfo( 'version' );
$expected = "<link rel='stylesheet' id='no-deps-no-version-css' href='http://example.com?ver=$ver' media='all' />\n";

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand All @@ -103,7 +103,7 @@ public function test_awkward_handles_are_supported_consistently( $handle ) {

$expected = "<link rel='stylesheet' id='$handle-css' href='http://example.com' type='text/css' media='all' />\n";

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand Down Expand Up @@ -157,7 +157,7 @@ public function test_protocols() {
$expected .= "<link rel='stylesheet' id='reset-css-ftp-css' href='{$wp_styles->base_url}ftp://yui.yahooapis.com/2.8.1/build/reset/reset-min.css?ver=$ver' type='text/css' media='all' />\n";

// Go!
$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );

// No styles left to print.
$this->assertSame( '', get_echo( 'wp_print_styles' ) );
Expand Down Expand Up @@ -186,8 +186,7 @@ public function test_inline_styles() {
wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );
wp_add_inline_style( 'handle', $style );

// No styles left to print.
$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand Down Expand Up @@ -215,7 +214,7 @@ public function test_inline_styles_concat() {
wp_add_inline_style( 'handle', $style );

wp_print_styles();
$this->assertSame( $expected, $wp_styles->print_html );
$this->assertEqualHTML( $expected, $wp_styles->print_html );
}

/**
Expand All @@ -233,7 +232,7 @@ public function test_inline_styles_concat() {
* @param string $expected Expected result.
*/
public function test_normalize_relative_css_links( $css, $expected ) {
$this->assertSame(
$this->assertEqualHTML(
$expected,
_wp_normalize_relative_css_links( $css, site_url( 'wp-content/themes/test/style.css' ) )
);
Expand Down Expand Up @@ -311,8 +310,7 @@ public function test_multiple_inline_styles() {
wp_add_inline_style( 'handle', $style1 );
wp_add_inline_style( 'handle', $style2 );

// No styles left to print.
$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand All @@ -337,7 +335,7 @@ public function test_plugin_doing_inline_styles_wrong() {

wp_add_inline_style( 'handle', "<style>{$style}</style>" );

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand All @@ -351,7 +349,7 @@ public function test_unnecessary_style_tags() {

wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand All @@ -361,12 +359,12 @@ public function test_unnecessary_style_tags() {
* @expectedDeprecated WP_Dependencies->add_data()
*/
public function test_conditional_inline_styles_are_also_conditional() {
$expected = '';
wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );
wp_style_add_data( 'handle', 'conditional', 'IE' );
wp_add_inline_style( 'handle', 'a { color: blue; }' );

$this->assertSameIgnoreEOL( $expected, get_echo( 'wp_print_styles' ) );
// Conditional styles are disabled.
$this->assertSame( '', get_echo( 'wp_print_styles' ) );
}

/**
Expand Down Expand Up @@ -399,7 +397,7 @@ public function test_wp_add_inline_style_for_handle_without_source() {
wp_enqueue_style( 'handle-three' );
wp_add_inline_style( 'handle-three', $style );

$this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
$this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
}

/**
Expand Down
Loading