Improve span merging logic #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group spans by style before merging to prevent different styles from interfering with each other's merge logic. Added a unit test to verify overlapping styles (bold and underline) are handled correctly during text insertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks a lot for this awesome library and the work you are doing! It is the best component for formatting text using Compose, that i found.
When we had a formatted text with 2 spans (like
**__Welcome__**), and we typed anainside, we got**__Wel**__a__**come__**(nested spans inside the other ones).This is a fix, that groups spans by style before merging to prevent different styles from interfering with each other's merge logic.
I also added a unit test to verify overlapping styles (bold and underline) are handled correctly during text insertion.