Fix tab switching data loss caused by race condition #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching tabs, there was a race condition between Zustand state update and React Router URL update. The useEffect that syncs model from URL was incorrectly calling setSelectedModel when activeTab and modelId were temporarily out of sync, causing form data to be cleared. Fix: Only sync model from URL when the active tab has no model selected yet, avoiding the race condition entirely. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
@codex improve this pr |
|
Summary
Testing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了桌面端 Playground 页面切换 Tab 时，原 Tab 中的 prompt 和参数被清空的问题。
原因：Tab 切换时 Zustand 状态和 URL 更新存在竞态条件，导致 setSelectedModel 被错误调用。