feat: add minimal live E2E test infrastructure #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test infrastructure for validating GoatSearch against live Cribl API: - tests/conftest.py: Splunk mock objects (MockService, kvstore, etc.) - tests/test_e2e.py: 10k event test with duplicate detection - tests/pytest.ini: IDE discovery pointer - tests/requirements.txt: Test dependencies - .github/workflows/live-test.yml: CI for main/develop branches - CLAUDE.md: AI code guidelines (performance, testing, gitflow) Tests detect pagination bugs via row_number() sequencing - same row_id appearing twice indicates repeated API offset requests. Requires secrets: CRIBL_CLIENT_ID, CRIBL_CLIENT_SECRET, CRIBL_TENANT, CRIBL_WORKSPACE Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register 'live' marker in pytest.ini to avoid warning - Filter DeprecationWarning from splunklib - Mark test as xfail (known pagination bug causes duplicates) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests must fail honestly - never bypass or suppress legitimate failures. Removed xfail marker; added Test Integrity section to CLAUDE.md documenting prohibited practices and correct failure handling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
row_number()sequencingChanges
tests/conftest.pytests/test_e2e.pytests/pytest.initests/requirements.txt.github/workflows/live-test.ymlCLAUDE.mdTest plan
ruff check tests/)Required Secrets
CRIBL_CLIENT_IDCRIBL_CLIENT_SECRETCRIBL_TENANTCRIBL_WORKSPACEGenerated with Claude Code