fix(models): align openai-compatible live check with SDK URLs #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make /models/check construct OpenAI-like chat/completions endpoints the same way OpenAI-style SDKs do (base_url + /chat/completions). This avoids false positives where the connectivity test passes but runtime requests 404 due to different URL construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueCell's
/models/checkendpoint could report a provider as reachable while runtime calls 404 because it built OpenAI-like endpoints differently than the OpenAI-style SDKs used at runtime.This change makes
/models/checkmirror SDK URL construction by appending/chat/completionsto the configuredbase_url(and requiring callers to include the version segment like/v1inbase_urlwhen needed).This fixes common setups where
base_urlincludes/openaior/apiprefixes (e.g. claude-relay-service) and the live check previously double-inserted/v1.