Skip to content

135 gps driver refactor #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panyab wants to merge 5 commits into
base: main
Choose a base branch
from
Open

135 gps driver refactor #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
613c8e5
addressed error that nonetype obj does not have fixType
panyab Mar 29, 2024
3beb6d3
edit req.txt
panyab Mar 29, 2024
6c15b79
Added more descriptive errors to gps driver, if statements to science…
panyab Mar 29, 2024
747f0c8
commented out air quality sensor temporarily
panyab Mar 29, 2024
73d1876
revert science driver
panyab Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions EosPayload/drivers/GPS_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,13 @@ def device_read(self, logger: logging.Logger) -> None:
try:
while True:
geo = self.gps.geo_coords()
gps_fix = geo.fixType # fix type
if int(gps_fix) < 3:
if geo is not None:
gps_fix = geo.fixType # fix type
if gps_fix == 0:
logger.info("No fix")
if int(gps_fix) < 3:
logger.info("GPS fix quality low, consider changing location")
else:
# Try again if we don't have a fix yet.
logger.info("Waiting for fix...")
self.thread_sleep(logger, 1)
Expand Down
8 changes: 4 additions & 4 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,21 @@
"name": "camera-driver",
"driver_class": "CameraDriver",
"device_id": "CAMERA_1",
"enabled": true
"enabled": false
},

{
"name": "cutdown-driver",
"driver_class": "CutdownDriver",
"device_id": "CUTDOWN",
"enabled": true
"enabled": false
},

{
"name": "valve-driver",
"driver_class": "ValveDriver",
"device_id": "VALVE",
"enabled": true
"enabled": false
},

{
Expand Down Expand Up @@ -75,7 +75,7 @@
"name": "electric-field-sensor",
"driver_class": "ElectricFieldSensor",
"device_id": "MISC_SENSOR_3",
"enabled": true
"enabled": false
}
]
}
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
git+https://github.com/VIP-LES/EosLib@v4.7.0#egg=EosLib
git+https://github.com/VIP-LES/EosLib@v.4.7.0#egg=EosLib
attrs==22.1.0
colorama==0.4.5
digi-xbee==1.4.1
Expand Down