-
Notifications
You must be signed in to change notification settings - Fork 1
Bugfix/noise vegas #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/noise vegas #246
Conversation
…aAverageTraceVarTimeIndpt for EA selection.
…out of range it was.
…due to pixel suppression.
|
This test failure is not a problem. It appears to run fine to generate files before and after, and the results are expected to be different so the comparison fails. |
|
@matthew-w-lundy thank you for checking that. |
njucarlchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes Look good. And conversions of a few runs on my machine succeeded without issue.
Changes to improve how V2DL3 handles noise including:
qStatsData.getCameraAverageTraceVarinstead ofqStatsData.getCameraAverageTraceVarTimeIndptfor EA selection. This is becauseqStatsData.getCameraAverageTraceVarTimeIndptexcludes all pixels that were excluded at any time during the run which can lead to calculating noise from very few pixels which can be unreliable.qStatsData.getCameraAverageTraceVarreturns an artificially low value. Added following procedure:avNonNegativeNoises /= nNonNegativeNoisesinside if/else statement to avoid a potential divide by 0 error.