v492.0 dev3 xgb #86
Merged
v492.0 dev3 xgb #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds XGBoost (XGB) machine learning support to the VERITAS analysis pipeline, along with updates to calibration data and time mask configurations.
Key Changes:
- Addition of XGBoost classification parameters and model file copying infrastructure
- Update of throughput correction factors for the V6_2025_2025s observation period
- Addition of 243 new time cut entries for runs 112698-114009
- Removal of commented documentation lines from multiple gamma/hadron cut files
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| ParameterFiles/XGB-classify-parameter.json | New configuration file defining energy and zenith angle bins for XGBoost classification |
| ParameterFiles/ThroughputCorrection.runparameter | Added reflectivity, g-factor, and s-factor values for V6_2025_2025s observing period |
| ParameterFiles/EFFECTIVEAREA.runparameter | Removed TELESCOPETYPECUTS configuration option |
| ParameterFiles/ANASUM.timemask.dat | Added 243 new time cut entries and corrected duplicate/formatting issues from previous entries |
| ParameterFiles/ANASUM.runparameter | Added XGBFILESUFFIX configuration parameter |
| GammaHadronCutFiles/*.dat | Cleaned up commented TMVACUTS documentation lines across 7 cut configuration files |
| DispXGB/copy_dispXGB.sh | New shell script to copy XGBoost model files from IRF production site |
| DispXGB/.gitignore | Added patterns to ignore V4, V5, and V6 version directories |
| DispXGB/AP/.gitkeep | Placeholder file to maintain empty directory structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@GernotMaier I've opened a new pull request, #87, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: GernotMaier <14001688+GernotMaier@users.noreply.github.com>
[WIP] WIP Address feedback from pull request #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.