Skip to content

TOF improvements #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KrisThielemans wants to merge 5 commits into
base: master
Choose a base branch
from
Open

TOF improvements #1674

KrisThielemans wants to merge 5 commits into from
+115 −202

Conversation

@KrisThielemans
Copy link
Collaborator

@KrisThielemans KrisThielemans commented Jan 19, 2026

  • add test for symmetric kernel of TOF (see TOF bin fix for RayTracingMatrix #1645)
  • remove zeroes from the cached projection matrix. Before, for every TOF bin, we still had row with the same size as the row of the non-TOF matrix. This meant a lot more memory was used than needed, and a potentially lot of multiplications with zero.

@KrisThielemans KrisThielemans self-assigned this Jan 19, 2026
@KrisThielemans
Copy link
Collaborator Author

KrisThielemans commented Jan 19, 2026

@z-k-li maybe you could have a look at this

@KrisThielemans
removed obsolete code in test_time_of_flight
f13f894 
the export_lor functions more or less copied functionality from
ProjMatrixByBin, and therefore had the same bug. I've removed them.
@KrisThielemans
trim zeroes in TOF projection matrix
423cdc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikEfth NikEfth Awaiting requested review from NikEfth

Assignees

@KrisThielemans KrisThielemans

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KrisThielemans