Specify MACE models by URL or by name #419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtischong
force-pushed
the
auto-download-mace-models
branch
2 times, most recently
from
7f33f7f to
816fb3c
Compare
curtischong
commented
Jan 24, 2026
| def __init__( | ||
| self, | ||
| model: str | Path | torch.nn.Module | None = None, | ||
| model: str | Path | torch.nn.Module | MACECalculator | None = None, |
Collaborator
Author
There was a problem hiding this comment.
I added the MACECalculator type since mace_mp returns it and it's an accepted type to this function
curtischong
force-pushed
the
auto-download-mace-models
branch
from
07207f1 to
50be710
Compare
curtischong
changed the title
curtischong
changed the title
curtischong
force-pushed
the
auto-download-mace-models
branch
from
d16cf0d to
a6ff97a
Compare
curtischong
changed the title
curtischong
force-pushed
the
auto-download-mace-models
branch
from
a6ff97a to
f851285
Compare
curtischong
commented
Jan 24, 2026
| try: | ||
| from mace.calculators.foundations_models import mace_mp | ||
|
|
||
| try: |
Collaborator
Author
There was a problem hiding this comment.
I added this second try catch since I checked to see when was mace_mp_urls added and it was only added 8 months ago, so older mace versions may not have it ACEsuit/mace@ab913f8
curtischong
force-pushed
the
auto-download-mace-models
branch
from
793e746 to
2b69f5e
Compare
curtischong
force-pushed
the
auto-download-mace-models
branch
from
2b69f5e to
c53be54
Compare
curtischong
commented
Jan 24, 2026
|
|
||
| return MaceModel( | ||
| model=mace_model, | ||
| model="https://github.com/ACEsuit/mace-mp/releases/download/mace_mp_0/2023-12-03-mace-128-L1_epoch-199.model", |
Collaborator
Author
There was a problem hiding this comment.
we don't want people with older models of mace to not run these tests
curtischong
force-pushed
the
auto-download-mace-models
branch
from
2c1cfa3 to
e6d0d08
Compare
curtischong
force-pushed
the
auto-download-mace-models
branch
from
e6d0d08 to
683f0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Mace model to allow people to pass in URLs to load models (#381) - so we don't need to call mace_mp