Skip to content

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Sep 30, 2025

unsure about

upstream problems

  • test tomophantom with numpy>=2
  • test tigre with numpy>=2
  • test astra-toolbox=*=cuda* with numpy>=2
  • test_CIL_CVXPy -> cvxpy -> scipy:
test_cil_vs_cvxpy_totalvariation_anisotropic (test_CIL_CVXPy.Test_CIL_vs_CVXPy.test_cil_vs_cvxpy_totalvariation_anisotropic) ... 
...
$CONDA_PREFIX/lib/python3.12/site-packages/scipy/sparse/_dia.py:140: UserWarning: result dtype changed due to the removal of value-based promotion from NumPy. Changed from int64 to int32.
  nnz += min(M+k,N)
...
$CONDA_PREFIX/lib/python3.12/site-packages/cvxpy/utilities/coeff_extractor.py:296: UserWarning: result dtype changed due to the removal of value-based promotion from NumPy. Changed from int32 to int64.
  P.row += offset

@casperdcl casperdcl self-assigned this Sep 30, 2025
@casperdcl casperdcl force-pushed the numpy-2 branch 4 times, most recently from 32b30db to 712e848 Compare October 1, 2025 13:37
@github-project-automation github-project-automation bot moved this to Todo in CIL work Oct 1, 2025
@casperdcl casperdcl added the help wanted Extra attention is needed label Oct 1, 2025
@casperdcl casperdcl moved this from Todo to In Progress in CIL work Oct 1, 2025
@gfardell gfardell requested review from gfardell and paskino October 14, 2025 14:24
@gfardell gfardell moved this from In Progress to Priority review in CIL work Oct 14, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that all the filters in this file return the same type as the input.

@casperdcl casperdcl force-pushed the numpy-2 branch 3 times, most recently from 7068ee6 to ace1d98 Compare October 30, 2025 09:57
@lauramurgatroyd
Copy link
Member

We will try to remove tomophantom dependency TomographicImaging/CIL-Demos#272

@lauramurgatroyd
Copy link
Member

For tomophantom, the next step is to test with the latest version on conda:

conda install -c httomo tomophantom

These are the recommended instructions on the readme. It may support numpy 2, we don't know.

If possible we would like to continue to support tomophantom for now, unless their code interface has changed.

If it has changed we will rebuild and release on ccpi channel tomophantom v2.0.0 with numpy 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

Status: Priority review

Development

Successfully merging this pull request may close these issues.

support numpy v2

4 participants