docs: add jekyll landing page #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
force-pushed
the
jekyll-landing
branch
from
d58c423 to
d32b8e6
Compare
casperdcl
force-pushed
the
jekyll-landing
branch
12 times, most recently
from
f3eb021 to
5a843cc
Compare
casperdcl
force-pushed
the
jekyll-landing
branch
from
5a843cc to
33f1b08
Compare
casperdcl
force-pushed
the
jekyll-landing
branch
2 times, most recently
from
0b3bcde to
263d6a6
Compare
casperdcl
force-pushed
the
jekyll-landing
branch
from
263d6a6 to
98fa31a
Compare
casperdcl
requested review from
a team,
MargaretDuff,
gfardell,
jakobsj,
lauramurgatroyd and
paskino
casperdcl
force-pushed
the
jekyll-landing
branch
from
cc46c34 to
b8034ef
Compare
Member
|
What is the best way for us to review this? Are there build instructions so we can view it, or could you set up a (short) meeting to show us it if you have it running locally? |
Member
Author
|
Instructions for testing are included in the docs in this PR. I ran this:
|
Member
|
If it is a quick fix, can this paragraph |
MargaretDuff
approved these changes
May 9, 2024
Member
MargaretDuff
left a comment
MargaretDuff
left a comment
There was a problem hiding this comment.
Looks good to me. Let's get it in so we have a landing page we can then adapt later on
Member
Author
not a quick fix unfortunately, but added to #1579 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Using jekyll (picked https://phlow.github.io/feeling-responsive which seems to be more maintained than https://mmistakes.github.io/minimal-mistakes)
content(moved to docs versions + updates #1579)/assets/img/){{site.basurl}}fix navigation dropdown relative links Phlow/feeling-responsive#276auto-fix_config.yml:urldocs/Makefilemake -C docs dirhtml web-deps web serveDocumentationHTMLunzip intoCILsubfolder before runninghttp.serverDocumentationHTML: use/prnum_mergeinstead of/nightlyadd more "widgets"moved to docs versions + updates #1579refs.bibentriesDescribe any testing you have performed
Link relevant issues
Checklist when you are ready to request a review
I have added docstrings in line with the guidance in the developer guideI have implemented unit tests that cover any new or modified functionalityCHANGELOG.md has been updated with any functionality changeContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.