Implement Quotes Board #1029

christolis · 2024-02-21T13:29:53Z

Closes #1027.

Screenshots

Configuration changes

Property	Description	Type	Default
`coolMessagesConfig.minimumReaction`	The minimum amount of reactions needed for the target message to be considered to the board channel.	int	5
`coolMessagesConfig.boardChannelPattern`	A pattern of the channel where messages that should be quoted get posted to.	String	`"quotes"`
`coolMessagesConfig.reactionEmoji`	The reaction emoji as unicode.	String	`"U+2B50"`

application/src/main/java/org/togetherjava/tjbot/features/Features.java

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

Taz03

add a message about config changes on main pr message, moderators said its hard to keep track of it otherwise

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

SquidXTV · 2024-10-15T09:53:07Z

maybe it makes more sense to implement this with the new forward feature in discord?

christolis · 2024-10-29T19:52:59Z

maybe it makes more sense to implement this with the new forward feature in discord?

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

SquidXTV · 2024-10-29T20:18:56Z

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

Good job <3
Maybe update the PR description (Screenshot) accordingly

christolis · 2024-10-29T20:21:43Z

@SquidXTV This is now a feature! With the latest changes, we are now forwarding messages instead of embedding messages. Good suggestion :)

Good job <3 Maybe update the PR description (Screenshot) accordingly

Thank you! I have updated the PR description. Thanks for pointing it out!

All requests have been resolved

application/src/main/java/org/togetherjava/tjbot/config/CoolMessagesBoardConfig.java

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java

application/config.json.template

application/build.gradle

suryatejess · 2025-06-27T18:50:15Z

gonna help with this

For this feature, the version of JDA had to be bumped to 5.1.2

* minimumReactions-5, star symbol instead of encoding * requests changes by zabuzard except for moving getBoardChannel down and markMessageAsProcessed * Following JavaDocs guidelines of making the first letter capital * code refactoring * refactor: use correct method for reactionsCount It turns out that for each event fired, every *single* damn time, messageReaction.hasCount() would always return false. No matter what. Terrible documentation from JDA's side. As a result, because of the ternary operator: messageReaction.hasCount() ? messageReaction.getCount() + 1 : 1 the result of `reactionsCount` would always end up holding the value of one. In the following changes, we use `messageReaction.retrieveUsers()` to get a list of the people reacted, get a `Stream<User>` from that and get its count. Much more reliable this way and it also happens to be more readable. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com> Co-authored-by: Chris Sdogkos <work@chris-sdogkos.com> Co-authored-by: Surya Tejess <74978874+suryatejess@users.noreply.github.com>

CLAassistant · 2025-06-28T14:10:18Z

All committers have signed the CLA.

Since 1ade409 (refactor: code review addressed by Zabuzard, 2025-06-28) primarily contains a generaly vague JavaDoc describing what the `QuoteBoardForwarder.java` class is doing, a more descriptive one replaces it. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

application/config.json.template

application/src/main/java/org/togetherjava/tjbot/config/Config.java

application/src/main/java/org/togetherjava/tjbot/config/QuoteBoardConfig.java

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

* rename coolMessagesConfig to quoteMessagesConfig * removed backticks for QuoteBoardForwarder and added a qualifier statement for QuoteBoardForwarder * param check for reactionEmoji * straight quotes instead of smart quotes * rename isCoolEmoji to isTriggerEmoji * early return when reactionsCount < config.minimumReactions() * early return for isCoolEmoji

Due to some hastiness in resolving the recent merge conflicts, some parts with "coolMessagesConfig" were not renamed to "quoteMessagesConfig". Take care of that. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

firasrg · 2025-12-26T12:48:33Z

Hello! I'm taking over this PR from @christolis. Planning to continue work starting tonight or tomorrow. Updates coming soon!

firasrg

Thank you for your efforts @christolis, I appreciate the fact that the feature works fine after ive done a small fix (latest commit), however, some parts in the code need to be reviewed carefully for the good of the application, i guess

firasrg · 2025-12-27T14:57:41Z

application/config.json.template

+    "quoteMessagesConfig": {
+        "minimumReactions": 2,
+        "boardChannelPattern": "quotes",
+        "reactionEmoji": "⭐"


I'd give this property a more readable name like triggerReaction, or simply reaction.

I'm not certain about putting emojis in code like this, instead, why not using the discord code of it :star:? I think it's cleaner

firasrg · 2025-12-27T15:00:58Z

application/config.json.template

        "pollIntervalInMinutes": 10
    },
+    "quoteMessagesConfig": {
+        "minimumReactions": 2,


I think to give this property a more readable name like triggerMinimumReactionsCount.

I think to increase the value, to better indicate the importance of the message, as 2 would be easy, if someone has at least one close friend on the server. A more appropriate value like 5 would be fairer

firasrg · 2025-12-27T15:03:05Z

application/config.json.template

    },
+    "quoteMessagesConfig": {
+        "minimumReactions": 2,
+        "boardChannelPattern": "quotes",


I'd give this property a more readable name like hostingChannel, targetChannel or simply channel

firasrg · 2025-12-27T15:10:13Z

application/config.json.template

        "videoLinkPattern": "http(s)?://www\\.youtube.com.*",
        "pollIntervalInMinutes": 10
    },
+    "quoteMessagesConfig": {


I think to give this parent property a more readable name such as quoteBoardConfig like the Java class name for consistency.

firasrg · 2025-12-27T15:14:25Z

application/src/main/java/org/togetherjava/tjbot/config/Config.java

    private final RSSFeedsConfig rssFeedsConfig;
    private final String selectRolesChannelPattern;
    private final String memberCountCategoryPattern;
+    private final QuoteBoardConfig quoteMessagesConfig;


Like I mentioned in config.json.template, it would be better to rename this to quoteBoardConfig for consistency

firasrg · 2025-12-27T15:50:10Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+    public void onMessageReactionAdd(MessageReactionAddEvent event) {
+        final MessageReaction messageReaction = event.getReaction();
+        boolean isTriggerEmoji = messageReaction.getEmoji().equals(triggerReaction);
+        long guildId = event.getGuild().getIdLong();


This variable is a bit faraway from where it's being called, i'd sugges to move it below the if statements

firasrg · 2025-12-27T15:58:20Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+     * @return the board text channel
+     */
+    private Optional<TextChannel> findQuoteBoardChannel(JDA jda, long guildId) {
+        return jda.getGuildById(guildId)


the return type of jda.getGuildById(guildId), is nullable. You have to add a control on that before going to .getTextChannelCache()

firasrg · 2025-12-27T16:02:24Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+     * @param guildId the guild ID
+     * @return the board text channel
+     */
+    private Optional<TextChannel> findQuoteBoardChannel(JDA jda, long guildId) {


Id rename this method to findQuoteBoardChannelByName() and add another param channelName;

I'd mark this method as static;

I'd move it above instance methods in this class.

firasrg · 2025-12-27T16:03:38Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+
+    private static final Logger logger = LoggerFactory.getLogger(QuoteBoardForwarder.class);
+    private final Emoji triggerReaction;
+    private final Predicate<String> isQuoteBoardChannelName;


As said below, i don't see a reason for this field isQuoteBoardChannelName

firasrg · 2025-12-27T16:06:16Z

application/src/main/java/org/togetherjava/tjbot/features/basic/QuoteBoardForwarder.java

+            .getTextChannelCache()
+            .stream()
+            .filter(channel -> isQuoteBoardChannelName.test(channel.getName()))
+            .findAny();


I think that the filter result must provide only one result, in case of multiple ones, an error should be thrown

A warning maybe but yeah.

Comments: 1. improved settings 2. using meaningful names 3. validations 4. some debug logs

christolis requested review from a team as code owners February 21, 2024 13:29

Taz03 marked this pull request as draft February 22, 2024 00:43

Taz03 assigned christolis Feb 22, 2024

christolis marked this pull request as ready for review February 28, 2024 10:27

tj-wazei previously requested changes Mar 1, 2024

View reviewed changes

tj-wazei reviewed Mar 1, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

christolis force-pushed the feature/cool-messages branch from 4a68771 to bc3b7d6 Compare March 1, 2024 23:54

christolis marked this pull request as draft March 2, 2024 00:03

christolis marked this pull request as ready for review March 2, 2024 00:59

christolis requested a review from tj-wazei March 2, 2024 01:00

christolis force-pushed the feature/cool-messages branch from 35ba891 to 47cdcb2 Compare March 20, 2024 09:29

Taz03 requested changes Mar 20, 2024

View reviewed changes

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java Outdated Show resolved Hide resolved

christolis force-pushed the feature/cool-messages branch from 47cdcb2 to 6d86c8f Compare April 4, 2024 09:07

christolis requested a review from Taz03 April 4, 2024 09:43

Taz03 previously approved these changes Apr 14, 2024

View reviewed changes

christolis dismissed Taz03’s stale review via 59dc245 May 17, 2024 22:42

christolis force-pushed the feature/cool-messages branch from ed3dbd5 to 59dc245 Compare May 17, 2024 22:42

ankitsmt211 added the config-changes if your PR contains any changes related to config file label May 18, 2024

christolis force-pushed the feature/cool-messages branch from 59dc245 to 35abd02 Compare October 6, 2024 11:44

christolis force-pushed the feature/cool-messages branch from 35abd02 to 7b19538 Compare October 29, 2024 19:50

christolis force-pushed the feature/cool-messages branch 2 times, most recently from bbde421 to 7d839d6 Compare October 29, 2024 20:13

SquidXTV previously approved these changes Oct 30, 2024

View reviewed changes

christolis requested a review from Taz03 October 30, 2024 10:20

tj-wazei previously approved these changes Oct 30, 2024

View reviewed changes

Zabuzard requested changes Jun 26, 2025

View reviewed changes

christolis dismissed stale reviews from tj-wazei and SquidXTV via 9f303cd June 26, 2025 10:50

christolis force-pushed the feature/cool-messages branch 2 times, most recently from 9f303cd to 8407d3f Compare June 27, 2025 09:00

christolis assigned suryatejess Jun 27, 2025

christolis added 3 commits June 28, 2025 16:59

feat(cool-messages): add configuration files

e1dcd79

feat(cool-messages): add primary logic

26e7811

feat(cool-message): forward messages instead of using embed

fb4fb5d

For this feature, the version of JDA had to be bumped to 5.1.2

christolis force-pushed the feature/cool-messages branch from 8407d3f to fb4fb5d Compare June 28, 2025 14:05

christolis requested a review from Zabuzard June 28, 2025 15:57

Zabuzard requested changes Jun 30, 2025

View reviewed changes

christolis force-pushed the feature/cool-messages branch 2 times, most recently from c3c1579 to a6085db Compare June 30, 2025 10:22

Zabuzard added the priority: normal label Jul 1, 2025

suryatejess and others added 2 commits December 26, 2025 01:46

Resolve merge conflicts

5db7cff

christolis requested a review from Zabuzard December 25, 2025 23:00

fix: more renaming to quoteMessageConfig

d2c1b29

Due to some hastiness in resolving the recent merge conflicts, some parts with "coolMessagesConfig" were not renamed to "quoteMessagesConfig". Take care of that. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>

christolis assigned firasrg Dec 26, 2025

fixes a single compilation error: "getCoolMessageConfig" is an old name

0946b54

firasrg requested changes Dec 27, 2025

View reviewed changes

christolis mentioned this pull request Dec 28, 2025

Add Starboard support #881

Open

applies FirasRG first review

a6efb2c

Comments: 1. improved settings 2. using meaningful names 3. validations 4. some debug logs

Uh oh!

Implement Quotes Board #1029

Are you sure you want to change the base?

Implement Quotes Board #1029

Uh oh!

Conversation

christolis commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Configuration changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Taz03 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SquidXTV commented Oct 15, 2024

Uh oh!

christolis commented Oct 29, 2024

Uh oh!

SquidXTV commented Oct 29, 2024

Uh oh!

christolis commented Oct 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

suryatejess commented Jun 27, 2025

Uh oh!

CLAassistant commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

firasrg commented Dec 26, 2025

Uh oh!

firasrg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christolis commented Feb 21, 2024 •

edited

Loading

CLAassistant commented Jun 28, 2025 •

edited

Loading

firasrg left a comment •

edited

Loading