Skip to content

Conversation

@peterschenk01
Copy link

Fixes #24

Now when generating the pack the blockstate json files are correct.

@voguelike
Copy link

this change was not able to return the log's rotation to it's intended function when testing

however this was:

"axis=x": { "model": f"{mod_namespace}:block/{block_name}", "z": 90 }

@peterschenk01
Copy link
Author

Could you please explain what the difference is? I visually don't see the difference between your solution and mine. Is there a functional one that I'm not aware of?

@voguelike
Copy link

for some reason, i was not able to get your solution to fix incorrect log rotation despite multiple attempts, i was only able to restore appropriate rotation behavior by modifying your solution.

if both work for you then there might be some odd element at play or that i might have messed something up somehow...

@Motschen
Copy link
Member

In my observations, this issue only occurs since 1.21.11, can you both confirm that?

@voguelike
Copy link

In my observations, this issue only occurs since 1.21.11, can you both confirm that?

nice catch! peterschenk01's solution works in 1.21.11 but not in 1.21.10 which is what i was using. my edit to the original solution happens to work in both.

@peterschenk01
Copy link
Author

In my observations, this issue only occurs since 1.21.11, can you both confirm that?

Ah that could be it. I can't confirm right now, but I did only test on 1.21.11

@Motschen
Copy link
Member

The only problem is that the pack previously used these rotation values in the blockstate definition to avoid z-fighting when logs of different orientations are placed next to each other.
I'll have to come up with another way to achieve this now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong log rotation

3 participants