Skip to content

Make random number generation thread local #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LilyIsTrans wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make random number generation thread local #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b153160
Make random number generation thread local
LilyIsTrans Dec 18, 2022
ac7aefe
Make random number generation thread local
LilyIsTrans Dec 18, 2022
c9a88a0
Fix typo making distribution thread local as well as generator
LilyIsTrans Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Walnut/src/Walnut/Random.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Walnut {

std::mt19937 Random::s_RandomEngine;
thread_local std::mt19937 Random::s_RandomEngine;
std::uniform_int_distribution<std::mt19937::result_type> Random::s_Distribution;

}
}
2 changes: 1 addition & 1 deletion Walnut/src/Walnut/Random.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace Walnut {
return glm::normalize(Vec3(-1.0f, 1.0f));
}
private:
static std::mt19937 s_RandomEngine;
thread_local static std::mt19937 s_RandomEngine;
static std::uniform_int_distribution<std::mt19937::result_type> s_Distribution;
};

Expand Down