Harmonization of the way we are computing sliding_rp_violations #4324
+2
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After optimizing all metrics, I realized a slight discrepancies in sliding_rp_violations compared with our way of computing cross-correlograms. This has to do with several things, I think it would be worth harmonizing everything
This PR uses compute_correlograms instead to solve the problem, but this would slightly change the results of the metrics. Who implemented that? Is it a feature, or should it be harmonized?