Move structured dtypes to base #4314
Merged
+50
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@samuelgarcia @chrishalcrow all in favor? |
Member
|
Sounds reasonable - seems like a good idea to define our important dtypes somewhere central. |
Member
Author
I'll move that here too! |
Member
Author
done! |
Member
Author
|
@chrishalcrow @samuelgarcia I think this is ready to merge |
chrishalcrow
approved these changes
Jan 13, 2026
Member
chrishalcrow
left a comment
chrishalcrow
left a comment
There was a problem hiding this comment.
I'm happy, as long as Sam is happy philosophically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since structured dtypes are used in different parts of the code, it makes more sense to move them to base from
node_pipeline.Will need to refactor #4299 #4302 #4301 accordingly