Jan 5: add tests, and fix demo #961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdulRahmanAlHamali
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mock to the existing test for
test_both_breakers_record_requeststo increase coverage and ensure mark_success is actually being called on both breakers.Adds a test to ensure that dual circuit breaker behaviour is entirely disabled when it's not specified (i.e., tests the behaviour when the Semian configuration looks like the old configuration).
Minor fix to the demo in
examples/dual_circuit_breaker_demo.rbto make the ExperimentFlags module a class.No functionality is being changed by this PR, just tests and the demo.