Skip to content

[Draft] use current metrics for adaptive circuit breaker reporting #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adriangudas wants to merge 1 commit into
base: pid-take-2
Choose a base branch
from
Draft

[Draft] use current metrics for adaptive circuit breaker reporting #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions lib/semian/adaptive_circuit_breaker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,31 +126,29 @@ def wait_for_window
Kernel.sleep(@sliding_interval)
end

def check_and_notify_state_transition(old_rate, new_rate, pre_update_metrics)
def check_and_notify_state_transition(old_rate, new_rate)
old_state = old_rate == 0.0 ? :closed : :open
new_state = new_rate == 0.0 ? :closed : :open

if old_state != new_state
notify_state_transition(new_state)
log_state_transition(old_state, new_state, new_rate, pre_update_metrics)
log_state_transition(old_state, new_state, new_rate)
end
end

def notify_state_transition(new_state)
Semian.notify(:state_change, self, nil, nil, state: new_state)
end

def log_state_transition(old_state, new_state, rejection_rate, pre_update_metrics)
requests = pre_update_metrics[:current_window_requests]

def log_state_transition(old_state, new_state, rejection_rate)
str = "[#{self.class.name}] State transition from #{old_state} to #{new_state}."
str += " success_count=#{requests[:success]}"
str += " error_count=#{requests[:error]}"
str += " rejected_count=#{requests[:rejected]}"
str += " success_count=#{metrics[:success]}"
str += " error_count=#{metrics[:error]}"
str += " rejected_count=#{metrics[:rejected]}"
str += " rejection_rate=#{(rejection_rate * 100).round(2)}%"
str += " error_rate=#{(pre_update_metrics[:error_rate] * 100).round(2)}%"
str += " ideal_error_rate=#{(pre_update_metrics[:ideal_error_rate] * 100).round(2)}%"
str += " integral=#{pre_update_metrics[:integral].round(4)}"
str += " error_rate=#{(metrics[:error_rate] * 100).round(2)}%"
str += " ideal_error_rate=#{(metrics[:ideal_error_rate] * 100).round(2)}%"
str += " integral=#{metrics[:integral].round(4)}"
str += " name=\"#{@name}\""

Semian.logger.info(str)
Expand Down
Loading