Skip to content

Spirv builder cleanup #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Firestar99 wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Spirv builder cleanup #497

Firestar99 wants to merge 18 commits into from

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Dec 22, 2025

Requires #484 #488 #496

@Firestar99
target-spec: remove crate rustc_codegen_spirv-target-specs
78ca2e7
@Firestar99
target-spec: generate target specs on the fly in spirv-builder
63b9e3c
@Firestar99
target-spec: move query_rustc_version to *spirv-types
4f318d6
@Firestar99
target-spec: add SpirvTarget type
fe13fb8
@Firestar99
target-spec compiletest: adjust to new target spec
52748a7
@Firestar99
target-spec compiletest: copy dylib loading from spirv-builder
22cdefd
@Firestar99
target-spec: add support for rust-gpu before rustc 1.85
8f197be
@Firestar99
target-spec: don't validate target env in spirv-builder
823b0c2
@Firestar99
build_script: replace enum MetadataPrintout with `struct BuildScrip…
56a46c3 
…tConfig` for more flexibility
@Firestar99
build_script: add forwarding of rustc warnings, with color support
8b83d58
@Firestar99
target-spec: accept both targets and target envs as valid targets
2c620bd
@Firestar99
spirv-builder: clap testing
a64583d
@Firestar99
Merge branch 'fwd_warnings' into no_artifacts
b55dcab 
# Conflicts:
#	crates/spirv-builder/src/lib.rs
@Firestar99
spirv-builder: when no artifact is produced, error instead of panic
86d74b6 
some cargo commands like clippy won't produce artifacts, so we want to ignore that error in cargo-gpu
@Firestar99
Merge branch 'no_artifacts' into spirv_builder_cleanup
5aad49d
@Firestar99
spirv-builder: move metadata file parsing to invoke_rustc
1ac317b
@Firestar99
spirv-builder: cleanup build_script.env_shader_spv_path implementation
cb0ea9e
@Firestar99
spirv-builder: make invoke_rustc take SpirvBuilder as &self
b09b3c5
@Firestar99 Firestar99 force-pushed the spirv_builder_cleanup branch from 3a1d676 to b09b3c5 Compare December 22, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb will be requested when the pull request is marked ready for review eddyb is a code owner

@LegNeato LegNeato Awaiting requested review from LegNeato LegNeato will be requested when the pull request is marked ready for review LegNeato is a code owner

@schell schell Awaiting requested review from schell schell will be requested when the pull request is marked ready for review schell is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Firestar99