fix: transform tool blocks to text before condensing (EXT-624) #10975
+409
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibility - Add toolUseToText() to convert tool_use blocks to text format - Add toolResultToText() to convert tool_result blocks to text format - Add convertToolBlocksToText() to transform all tool blocks in message content - Add transformMessagesForCondensing() to apply transformation to messages - Apply transformation in summarizeConversation() before API call - Add 18 unit tests for full coverage Fixes LiteLLM/Bedrock error: 'Bedrock doesn't support tool calling without tools= param specified' When condensing conversations containing tool_use/tool_result blocks, Bedrock requires the tools parameter. By transforming these blocks to text representations, we remove this dependency while preserving semantic meaning for summarization.
dosubot
bot
added
size:L
Contributor
Review complete. No issues identified. The implementation correctly transforms tool_use and tool_result blocks to text representations before sending for summarization, resolving the Bedrock/LiteLLM compatibility issue. The code is well-structured with comprehensive test coverage (18 new tests). Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using LiteLLM with Bedrock as the provider, conversation condensing fails with error:
This occurs because conversation history contains
tool_useandtool_resultblocks, but during condensing notoolsparameter is passed to the API call.Solution
Transform tool blocks to text representations before sending for summarization. This removes the structural dependency on the
toolsparameter while preserving semantic meaning for the LLM to summarize.Changes
toolUseToText()- converts tool_use blocks to readable text formattoolResultToText()- converts tool_result blocks to readable text formatconvertToolBlocksToText()- processes content arraystransformMessagesForCondensing()- applies transformation to message arrayssummarizeConversation()before API callExample Transformation
Before (tool_use block):
{ "type": "tool_use", "id": "toolu_123", "name": "read_file", "input": { "path": "src/index.ts" } }After (text block):
{ "type": "text", "text": "[Tool Use: read_file]\npath: src/index.ts" }Linear Issue
https://linear.app/roocode/issue/EXT-624