fix: handle ByteString error in embedder validation flow #10974
+128
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10973
Description
This PR attempts to address the ByteString conversion error that occurs when non-ASCII characters (e.g., Cyrillic) are present in the API key or base URL configuration for the codebase indexer.
Root Cause: HTTP headers only support Latin-1 characters (values 0-255). When the OpenAI SDK or fetch API tries to set headers containing characters with values > 255, it throws the ByteString error.
Implementation:
handleValidationErrorfunction insrc/services/code-index/shared/validation-helpers.tscommon:errors.api.invalidKeyInvalidCharstranslation keyThis approach is consistent with the existing ByteString error handling in
src/api/providers/utils/error-handler.ts.Feedback and guidance are welcome.
Test Procedure
Pre-Submission Checklist
Documentation Updates
Additional Notes
The translation key
common:errors.api.invalidKeyInvalidCharsalready exists in all supported locales, so no new translations were needed.