Add quality checks to marketing site deployment workflows

[mp-roocode]

Related GitHub Issue

Closes: # #10950

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

---

Important

Add quality checks to deployment workflows and update Vercel CLI version in website-deploy.yml and website-preview.yml.

• Workflows:
  • Add quality-checks job to website-deploy.yml and website-preview.yml for linting, type checking, and building.
  • Update Vercel CLI installation to vercel@latest in both workflows.
  • Add concurrency control to cancel in-progress runs for both workflows.
• Deployment:
  • deploy job in website-deploy.yml now depends on quality-checks.
  • preview job in website-preview.yml now depends on quality-checks.
• Misc:
  • Add PR comment with preview link in website-preview.yml.

^{This description was created by for e52a743. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review complete. No issues found. The PR correctly adds quality checks (lint, type-check, build) to both deployment workflows with proper job dependencies, appropriate concurrency controls, and stable Vercel CLI version.

Previous reviews

• f61f76a: Review #1

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[roomote]

📋 Related to Rules PR

This PR implements the quality gates defined in PR #10950.

Relationship:

• PR Add marketing site deployment quality gate rules #10950 adds the rules requiring quality checks for marketing site deployments
• This PR (10959) implements those rules by modifying the workflow files

Recommended merge order:

1. Merge PR Add marketing site deployment quality gate rules #10950 first (establishes the rules)
2. Merge this PR (10959) second (implements the rules)

What this PR fixes:

• 🔴 Prevents broken code from being deployed to production/preview
• 🔴 Eliminates race condition between quality checks and deployment
• 🟡 Ensures quality checks run before deployment (not in parallel)

See PR #10950 for the complete analysis of issues found.

[roomote]

🚀 Updated Implementation Instructions

After deeper analysis, I found 2 additional critical issues that should be fixed in this PR:

Additional Issues Found

🟡 Issue #6: No Deployment Concurrency Controls

• Multiple deployments can run in parallel if commits are pushed quickly
• Last deployment to finish wins - could deploy older code over newer code
• Example: Commit A (takes 3min) starts, then Commit B (takes 2min) starts. B finishes first, then A overwrites it with stale code.

🟡 Issue #7: Using Unstable Vercel CLI (vercel@canary)

• Both workflows use vercel@canary (bleeding-edge, unstable releases)
• Could introduce breaking changes unexpectedly
• Should use vercel@latest for stable deployments

Complete Changes Needed

See /tmp/workflow-changes-complete.md in the worker for the complete file examples that include:

1. ✅ Quality checks job (already in this PR)
2. ✅ Concurrency controls (NEW)
3. ✅ Stable Vercel CLI version (NEW)

Quick Summary of Additional Changes

For both files, add at the top (after on:, before env:):

concurrency:
    group: deploy-roocode-com  # Use preview-roocode-com-${{ github.ref }} for preview
    cancel-in-progress: true

For both files, change:

run: npm install --global vercel@latest  # Changed from vercel@canary

Updated Rules

The rules in PR #10950 have been updated to include requirements for:

• Deployment concurrency controls
• Vercel CLI version stability

These changes ensure:

• ✅ No deployment race conditions
• ✅ Stable, deterministic deployments
• ✅ Newer code always wins over stale code