Fix rendering of multiple images with reflinks #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Your changes look great, and I appreciate the effort you put into fixing the rendering issues for multiple images with reflinks. I’ve reviewed the changes, and everything looks good to me. Thank you for your contribution, @alisinabh! 🎉 |
Owner
|
ty @alisinabh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120 and #149
There is one test case (
[[]]]text] [reference]\n[reference]: some_url) that did not have the right expectation. I have changes that test to reflect what Github markdown does but please let me know if this is wrong.