Skip to content

Conversation

@AllenAJ
Copy link

@AllenAJ AllenAJ commented Dec 28, 2025

  • Added an Advocates Welcome Kit to help onboard new community members.
  • Enhanced the "Updating a Request" guide with functional code examples.
  • Updated the Node.js Quickstart with Viem integration and Request update logic.
  • Updated FAQ and navigation to include advocate resources.

Summary by CodeRabbit

  • Documentation
    • Launched Advocates Welcome Kit guide with mission, getting-started steps, rewards, and support details
    • Expanded "Update a request" docs with a summary of actions, richer examples, and practical Node.js quickstart guidance for performing updates
    • Added FAQ entry on how to contribute as an advocate

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Walkthrough

Adds an Advocates Welcome Kit doc and navigation/FAQ entries; replaces placeholder content with concrete "Update a request" examples in the Node.js quickstart and expands the Request Client "Updating a request" guide with an actions table and usage examples. All edits are documentation-only.

Changes

Cohort / File(s) Summary
New Advocates Program Doc
docs/general/advocates-welcome-kit.md
Adds the Advocates Welcome Kit with mission, getting started steps, reward program (points & tiers), monthly pool, and support contacts.
Navigation & FAQ Updates
docs/SUMMARY.md, docs/faq.md
Inserts "Advocates Welcome Kit" into SUMMARY.md General section and adds a new FAQ entry linking to the new doc; adjusts FAQ ordering.
SDK Quickstart (Node) Update
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md
Replaces placeholder "How to update a request" with a concrete section and example showing loading a request by ID, accepting as payer using a signatureProvider, and waiting for confirmation; updates viem guidance to recommend using ethers v5 adapters for Node.js.
Request Client — Updating Guide
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
Replaces HTML action table with a Markdown "Summary of Actions" table and adds examples for initializing the client and performing accept, cancel, increase, and reduce operations (notes on signatureProvider and waiting for confirmations).

Sequence Diagram(s)

(omitted — changes are documentation updates and do not introduce new executable control flow requiring a sequence diagram)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding an Advocates Welcome Kit and updating the SDK quickstart documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MantisClone
Copy link
Member

Hello @AllenAJ, thank you for submitting your first pull request to the docs.request.network repository. We value your contribution and encourage you to review our contribution guidelines to ensure your submission meets our standards. Please note that every merged PR is automatically enrolled in our Best PR Initiative, offering a chance to win $500 each quarter. Our team is available via GitHub Discussions or Discord if you have any questions. Welcome aboard!

@MantisClone
Copy link
Member

Thank you for your submission! As you prepare for the review process, please ensure that your PR title, description, and any linked issues fully comply with our contribution guidelines. A clear explanation of your changes and their context will help expedite the review process. Every merged PR is automatically entered into our Best PR Initiative, offering a chance to win $500 every quarter. We appreciate your attention to detail and look forward to reviewing your contribution!

@greptile-apps
Copy link

greptile-apps bot commented Dec 28, 2025

Greptile Summary

This PR enhances the documentation by adding an Advocates Welcome Kit for community onboarding and completing the "Updating a Request" guide with working code examples. The Node.js quickstart now includes a request update section and viem integration example.

Key Changes:

  • Added docs/general/advocates-welcome-kit.md with program details, reward tiers, and onboarding steps
  • Expanded updating-a-request.md with complete code examples for accept, cancel, increase/decrease amount operations
  • Added "Update a request" section to Node.js quickstart with example code
  • Included viem integration example for payment operations (converts viem clients to ethers v5 signers)
  • Updated FAQ and navigation to reference the new advocate resources

Issues Found:

  • Viem integration code uses mainnet chain instead of sepolia (inconsistent with rest of quickstart)
  • Viem WalletClient.transport conversion to ethers Web3Provider may not work correctly - the browser quickstart shows a more robust conversion approach
  • The addStakeholders action was removed from the updating-a-request table (was in original version based on diff)

Confidence Score: 3/5

  • Safe to merge with minor corrections needed for viem integration code
  • The documentation additions are well-structured and helpful. However, the viem integration example has logical issues (wrong chain, potentially incorrect Web3Provider conversion) that could mislead users. The code examples for request updates appear correct based on SDK API reference.
  • Pay close attention to quickstart-node.js.md - the viem integration code needs verification and correction

Important Files Changed

Filename Overview
docs/general/advocates-welcome-kit.md New advocate program onboarding document with reward structure and getting started guide
docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md Comprehensive update to request update guide with code examples; removed addStakeholders action from table
docs/advanced/request-network-sdk/get-started/quickstart-node.js.md Added request update section and viem integration example; viem code may not work correctly with SDK

Sequence Diagram

sequenceDiagram
    participant User as Developer/Advocate
    participant Docs as Documentation
    participant SDK as Request Network SDK
    participant Node as Request Node
    participant IPFS as IPFS Network
    
    Note over User,Docs: New Advocate Onboarding Flow
    User->>Docs: Access Advocates Welcome Kit
    Docs-->>User: Program details, tools, rewards
    
    Note over User,SDK: Request Update Workflow
    User->>SDK: Initialize RequestNetwork client<br/>with signatureProvider
    User->>SDK: fromRequestId(requestId)
    SDK->>Node: Fetch request data
    Node->>IPFS: Retrieve request content
    IPFS-->>Node: Request data
    Node-->>SDK: Request object
    SDK-->>User: Request instance
    
    User->>SDK: request.accept(signerIdentity)
    SDK->>SDK: Sign update with private key
    SDK->>Node: Submit update transaction
    Node->>IPFS: Store update
    Node->>Blockchain: Store CID hash
    SDK-->>User: Updated request data
    
    User->>SDK: request.waitForConfirmation()
    SDK->>Node: Poll for confirmation
    Node-->>SDK: Confirmed
    SDK-->>User: Confirmed request data
    
    Note over User,SDK: Payment Flow (with viem)
    User->>SDK: Create viem clients
    User->>SDK: Convert to ethers v5 signer
    SDK->>SDK: Check funds & approval
    User->>SDK: payRequest(requestData, signer)
    SDK->>Blockchain: Execute payment transaction
    Blockchain-->>SDK: Transaction receipt
    SDK-->>User: Payment complete
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (4)

  1. docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 197-200 (link)

    logic: Uses mainnet chain but the rest of the quickstart uses Sepolia. Should be consistent.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  2. docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 205-207 (link)

    logic: Chain should match Sepolia for consistency with the rest of the quickstart.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  3. docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 211-213 (link)

    logic: Should use sepolia instead of mainnet for consistency.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

  4. docs/advanced/request-network-sdk/get-started/quickstart-node.js.md, line 210-214 (link)

    logic: The viem WalletClient.transport is not directly compatible with ethers Web3Provider. Check the implementation in quickstart-browser.md:274-284 which properly extracts account and chain info from the walletClient before creating the provider.

5 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6a93ce and 7c6248a.

📒 Files selected for processing (5)
  • docs/SUMMARY.md
  • docs/advanced/request-network-sdk/get-started/quickstart-node.js.md
  • docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
  • docs/faq.md
  • docs/general/advocates-welcome-kit.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*

⚙️ CodeRabbit configuration file

**/*: - Only comment on issues that would block merging — ignore minor or stylistic concerns.

  • Restrict feedback to errors, security risks, or functionality-breaking problems.
  • Do not post comments on code style, formatting, or non-critical improvements.
  • Keep reviews short: flag only issues that make the PR unsafe to merge.
  • Limit review comments to 3–5 items maximum, unless additional blockers exist.
  • Group similar issues into a single comment instead of posting multiple notes.
  • Skip repetition — if a pattern repeats, mention it once at a summary level only.
  • Do not add general suggestions; focus strictly on merge-blocking concerns.
  • If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
  • Avoid line-by-line commentary unless it highlights a critical bug or security hole.
  • Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
  • Ignore minor optimization opportunities — focus solely on correctness and safety.
  • Provide a top-level summary of critical blockers rather than detailed per-line notes.
  • Comment only when the issue must be resolved before merge — otherwise, remain silent.
  • When in doubt, err on the side of fewer comments — brevity and blocking issues only.
  • Avoid posting any refactoring issues

Files:

  • docs/advanced/request-network-sdk/get-started/quickstart-node.js.md
  • docs/general/advocates-welcome-kit.md
  • docs/SUMMARY.md
  • docs/faq.md
  • docs/advanced/request-network-sdk/sdk-guides/request-client/updating-a-request.md
🪛 LanguageTool
docs/general/advocates-welcome-kit.md

[style] ~20-~20: The noun “invitation” is usually used instead of ‘invite’ in formal writing.
Context: ...ols * Notion: You will receive an invite to our private Advocates workspace. * ...

(AN_INVITE)

🪛 markdownlint-cli2 (0.18.1)
docs/general/advocates-welcome-kit.md

47-47: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Greptile Review

@MantisClone
Copy link
Member

Regarding the Greptile feedback about addStakeholders being removed from the updating-a-request.md table - please keep this action in the Summary of Actions table. It's a valid update action for encrypted requests:

| **addStakeholders** | Grant 1 or more third parties access to view an encrypted request | Payee, Payer, or Third Party |

We'll add this back in a follow-up commit.

- Replace broken viem-to-ethers code in Node.js quickstart with note
  explaining that viem http() transport isn't EIP-1193 compatible
- Restore addStakeholders row to updating-a-request.md table

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@MantisClone
Copy link
Member

I've pushed a fix commit (087dc01) to your branch that:

  1. Replaces the viem tab in quickstart-node.js.md with a note explaining that viem-to-ethers patterns are for browser wallets, and pointing users to the ethers v5 approach
  2. Restores the addStakeholders row in the updating-a-request.md table

The rest of the PR looks good - the Advocates Welcome Kit and the Update a Request examples are helpful additions. Thanks for the contribution!

Change Discord link from discord.gg/request to request.network/discord
to match existing docs pattern.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@MantisClone MantisClone self-assigned this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎫 Backlog

Development

Successfully merging this pull request may close these issues.

2 participants