Updated fet.py to treat nf and W according to ngspice and BSIM conventions. W is total width, and FET layouts now have correct width_finger=W/nf #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the finger width check could be more sophisitcated. Currently W needs to be a multiple of fingers
Member
|
We will need to make sure this passes for existing pcells: |
|
Ran the stress test and found DRC errors. Layer mapping issues need to be addressed. The fractional finger width is ignored, ensuring that there are no layout symmetry issues. |
Landflier
force-pushed
the
dev
branch
3 times, most recently
from
ce1ea31 to
2c4dc74
Compare
Previous commit, optionB capcitor gets extracted as cap_mim_2f0_m4m5_noshield
Previous commit, optionB capcitor gets extracted as cap_mim_2f0_m4m5_noshield
Landflier
force-pushed
the
dev
branch
5 times, most recently
from
193dc86 to
aff7f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also generated a stress-test script to generate FET layouts. nf and W seem to behave properly. There are a bunch of DRC errors, but I think these stem from other parts of the layout script. Could be worth checking out
I am attaching the script + generated gds
stress_test_gds_and_py_script.zip